Enhancement: onUpdate and onDetach APIs for dom pragma#829
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a5ce18c:
|
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 127 127
Lines 8034 8040 +6
Branches 1861 1864 +3
=======================================
+ Hits 7845 7851 +6
Misses 189 189
Continue to review full report at Codecov.
|
matt-gadd
approved these changes
Sep 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Adds two new APIs for the
dompragma,onUpdateandonDetachthat are called when the dom node is updated and removed respectively. This will enable support for integrations such as mounting a react component within a Dojo application.Resolves #828