Skip to content

Clean up across the READMEs#81

Merged
agubler merged 5 commits into
dojo:masterfrom
agubler:readme-clean-up
Sep 4, 2018
Merged

Clean up across the READMEs#81
agubler merged 5 commits into
dojo:masterfrom
agubler:readme-clean-up

Conversation

@agubler
Copy link
Copy Markdown
Member

@agubler agubler commented Aug 24, 2018

Type: bug

The following has been addressed in the PR:

Description:

Adds prettier for markdown and cleans up references

Comment thread src/has/README.md Outdated
- [Conditional Module Loading](#conditional-module-loading)
- [Static Features](#static-features)
- [Features](#features)
- [Feature Branching](#feature-branching) - [Included Features](#included-features) - [Adding a Feature Test/Feature Detection](#adding-a-feature-testfeature-detection) - [Conditional Module Loading](#conditional-module-loading) - [Static Features](#static-features)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is pushing this onto one line correct?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, good spot.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed up @dylans

@agubler agubler requested a review from dylans August 24, 2018 15:37
@agubler
Copy link
Copy Markdown
Member Author

agubler commented Aug 28, 2018

@dylans do you think you'll be able to review this?

Copy link
Copy Markdown
Contributor

@JamesLMilner JamesLMilner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@agubler agubler merged commit 0a8ada8 into dojo:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants