Set total when side-loading data into a resource#701
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #701 +/- ##
==========================================
+ Coverage 97.76% 97.79% +0.02%
==========================================
Files 119 119
Lines 6924 6925 +1
Branches 1572 1572
==========================================
+ Hits 6769 6772 +3
+ Misses 155 153 -2
Continue to review full report at Codecov.
|
6 tasks
agubler
approved these changes
Mar 27, 2020
agubler
pushed a commit
to agubler/framework
that referenced
this pull request
Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
This PR fixes an issue where the data total was not being set when
setwas used to side-load the resource data.Resolves #700