Auto detect custom element child type#502
Merged
Merged
Conversation
rorticus
approved these changes
Aug 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
The previous attempt to auto detect childType only worked when the CE javascript was loaded before the element was created. If the CE javascript was loaded after the custom element is created then it caused issues with hydration (as dojo didn't know what was a Dojo CE and what wasn't).
The current behaviour only supports a single specified child type per widget and this auto detection mirrors that. It is assumed that if there are any children with a
-character that the childType isDOJOotherwise it'sNODE/TEXT.If a widget is specifically for non Dojo CE children then the existing configuration can be used.
Note: Additionally empty text nodes are filtered out from the childNodes
Supersedes #494
Resolves #304