Bug: Value doesn't update when setting the value of select in UI#170
Merged
Conversation
tomdye
approved these changes
Nov 14, 2018
agubler
added a commit
to agubler/framework
that referenced
this pull request
Nov 14, 2018
…o#170) * failing unit test for changing select option in the ui * set the select value before attempting to set the node value * test for programmically updating the select value * rename tests
agubler
added a commit
that referenced
this pull request
Nov 14, 2018
… (#171) * failing unit test for changing select option in the ui * set the select value before attempting to set the node value * test for programmically updating the select value * rename tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
The select value doesn't set because the dom value has already been updated, this means that because we run
setValuebefore setting theselect-valueproperty the mechanism resets the value to the previous select value.Make sure we set the
select-valueon the select node before we try and set the actual value.