Skip to content
This repository was archived by the owner on Oct 26, 2019. It is now read-only.

update spec and regen code - #237

Closed
CliffLin wants to merge 1 commit into
docker-php:1.24from
CliffLin:1.24
Closed

update spec and regen code#237
CliffLin wants to merge 1 commit into
docker-php:1.24from
CliffLin:1.24

Conversation

@CliffLin

Copy link
Copy Markdown

change datetime to string
fix service find url typo

@leo108

leo108 commented Apr 9, 2017

Copy link
Copy Markdown

@joelwurtz Is this project still alive? This pr fixes issue #238

@joelwurtz

Copy link
Copy Markdown
Member

Yes it is still alive, just have 0 time for the past months to deal with current problems. I try to merge directly if the PR is good enough, but this is not the case here.

There is the possibility to use a specific date time format in jane, it will be far better than using a string.

@CliffLin

Copy link
Copy Markdown
Author

@joelwurtz ,
I cannot find any solution for the problem about nanoseconds format.
And I add the date-time format Y-m-d\TH:i:s.uuP, the double u is a tricky way to parse for nanosecond

@joelwurtz

Copy link
Copy Markdown
Member

This should be good on 2.0

@joelwurtz joelwurtz closed this Mar 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants