copy(): Copy files or folders from a container to a tar stream. copyToDi... - #109

Apparently Spl is in php 5.x, so just tried:
$fd=SplFileObject("/tmp/foo", 'w+');
and it give "Call to undefined function SplFileObject"
http://php.net/manual/en/spl.configuration.php does not indicate any run time configuration.
Using Ubuntu 14.04.
Suggestions?

Hey Sean, SplFileObject is actually an object, so you need to instantiate it with new, like this:

$fd = new SplFileObject('/tmp/foo', 'w+');

Oops :-)

Using fopen rather than SplFileObject due to stream_copy_to_stream()

Hi, can this be committed please?

And sorry for being a coding style nazi

Hey @Boran, sorry for the delay. Before this can be merged, indentation and CS needs to be fixed:

• use 4 spaces for indentation
• no new line before the closing } of an if

I've been waiting 6 months to get this small patch integrated, hardly motivating..

The failing test is not related to this PR. Looks good to me 👍

I've been waiting 6 months to get this small patch integrated, hardly motivating..

You are right, and I should have handled your PR earlier and in a more swift manner. That being said, there still are inconsistencies in your PR regarding to CS, and you merged master in your branch instead of rebasing your branch on master, which screws up the history.

Anyway, I made a new PR based on your commits, fixed the CS, then rebased against master and squashed the commits in #128

Oops, apologies for that I had forgotten the correct procedure. Thanks for sorting it out:)

Sean Boran

On 04 Sep 2015, at 16:32, Geoffrey Bachelet notifications@github.com wrote:

I've been waiting 6 months to get this small patch integrated, hardly motivating..

You are right, and I should have handled your PR earlier and in a more swift manner. That being said, there still are inconsistencies in your PR regarding to CS, and you merged master in your branch instead of rebasing your branch on master, which screws up the history.

Anyway, I made a new PR based on your commits, fixed the CS, then rebased against master and squashed the commits in #128

—
Reply to this email directly or view it on GitHub.

No problem. Just merged #128