Skip Python GC on Windows 3.14 shutdown

devtrack · devtrack · Jan 13, 2026 · Jan 13, 2026 · Jan 14, 2026 · Jan 14, 2026
commit 302f1d2e38568e388406109ec8e3946a2dda97c8
diff --git a/.github/workflows/windows-build-test-3.14.yml b/.github/workflows/windows-build-test-3.14.yml
@@ -46,7 +46,6 @@ jobs:
       - name: Embedding tests (.NET Core)
         run: dotnet test --runtime any-x64 --framework net8.0 --logger "console;verbosity=detailed" src/embed_tests/
         if: always()
-        continue-on-error: true
 
       - name: Python Tests (.NET Core)
         run: pytest --runtime coreclr

diff --git a/src/runtime/PythonEngine.cs b/src/runtime/PythonEngine.cs
@@ -143,6 +143,20 @@
             get { return Marshal.PtrToStringAnsi(Runtime.Py_GetVersion()); }
         }
 
+        internal static Version GetPythonVersion()
+        {
+            string? versionText = Version;
+            if (string.IsNullOrWhiteSpace(versionText))
+            {
+                return new Version(0, 0);
+            }
+
+            string versionPart = versionText.Split(' ')[0];
+            return Version.TryParse(versionPart, out Version? parsed)
+                ? parsed
+                : new Version(0, 0);
+        }
+
         public static string BuildInfo
         {
             get { return Marshal.PtrToStringAnsi(Runtime.Py_GetBuildInfo()); }

diff --git a/src/runtime/Runtime.cs b/src/runtime/Runtime.cs
@@ -262,7 +262,7 @@
             if (!HostedInPython && !ProcessIsTerminating)
             {
                 // avoid saving dead objects
-                TryCollectingGarbage(runs: 3);
+                TryCollectingGarbage(runs: 3, pythonGC: !ShouldSkipPythonGcOnShutdown);
 
                 RuntimeData.Stash();
             }
@@ -275,7 +275,8 @@
             RemoveClrRootModule();
 
             TryCollectingGarbage(MaxCollectRetriesOnShutdown, forceBreakLoops: true,
-                                 obj: true, derived: false, buffer: false);
+                                 obj: true, derived: false, buffer: false,
+                                 pythonGC: !ShouldSkipPythonGcOnShutdown);
             CLRObject.creationBlocked = true;
 
             NullGCHandles(ExtensionType.loadedExtensions);
@@ -294,8 +295,12 @@
             DisposeLazyObject(hexCallable);
             PyObjectConversions.Reset();
 
-            PyGC_Collect();
-            bool everythingSeemsCollected = TryCollectingGarbage(MaxCollectRetriesOnShutdown);
+            if (!ShouldSkipPythonGcOnShutdown)
+            {
+                PyGC_Collect();
+            }
+            bool everythingSeemsCollected = TryCollectingGarbage(MaxCollectRetriesOnShutdown,
+                                                                 pythonGC: !ShouldSkipPythonGcOnShutdown);
             Debug.Assert(everythingSeemsCollected);
 
             Finalizer.Shutdown();
@@ -328,7 +333,8 @@
         const int MaxCollectRetriesOnShutdown = 20;
         internal static int _collected;
         static bool TryCollectingGarbage(int runs, bool forceBreakLoops,
-                                         bool obj = true, bool derived = true, bool buffer = true)
+                                         bool obj = true, bool derived = true, bool buffer = true,
+                                         bool pythonGC = true)
         {
             if (runs <= 0) throw new ArgumentOutOfRangeException(nameof(runs));
 
@@ -340,7 +346,10 @@
                 {
                     GC.Collect();
                     GC.WaitForPendingFinalizers();
-                    pyCollected += PyGC_Collect();
+                    if (pythonGC)
+                    {
+                        pyCollected += PyGC_Collect();
+                    }
                     pyCollected += Finalizer.Instance.DisposeAll(disposeObj: obj,
                                                                  disposeDerived: derived,
                                                                  disposeBuffer: buffer);
@@ -366,6 +375,20 @@
         public static bool TryCollectingGarbage(int runs)
             => TryCollectingGarbage(runs, forceBreakLoops: false);
 
+        static bool ShouldSkipPythonGcOnShutdown
+        {
+            get
+            {
+                if (!IsWindows)
+                {
+                    return false;
+                }
+
+                Version version = PythonEngine.GetPythonVersion();
+                return version >= new Version(3, 14);
+            }
+        }
+
         static void DisposeLazyObject(Lazy<PyObject> pyObject)
         {
             if (pyObject.IsValueCreated)