Skip to content

Enh add snapshot feature WIP#900

Open
gst wants to merge 27 commits intodevpi:mainfrom
gst:enh-add-snapshot-feature
Open

Enh add snapshot feature WIP#900
gst wants to merge 27 commits intodevpi:mainfrom
gst:enh-add-snapshot-feature

Conversation

@gst
Copy link
Copy Markdown

@gst gst commented Jun 20, 2022

Would solve #897

@gst
Copy link
Copy Markdown
Author

gst commented Jun 20, 2022

@fschulze wdyt of this ?

@gst gst changed the title Enh add snapshot feature Enh add snapshot feature WIP Jun 21, 2022
Comment thread .gitignore Outdated
Comment thread server/devpi_server/keyfs_sqlite_fs.py Outdated
Comment thread server/devpi_server/main.py Outdated
pyramid_config.add_view_predicate('content_type', ContentTypePredicate)

# snapshoting
pyramid_config.add_route("/+snapshot/{user}/{index}", "/+snapshot/{user}/{index}")
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the COPY HTTP method, if you have good arguments against that, then I would like /{user}/{index}/+copy. Snapshotting should be an option selected with ?snapshot.

Comment thread server/devpi_server/model.py Outdated
Comment thread server/devpi_server/views.py Outdated
Comment thread server/devpi_server/views.py Outdated
Comment thread server/devpi_server/views.py Outdated
Comment thread server/devpi_server/views.py Outdated
@fschulze
Copy link
Copy Markdown
Contributor

As a summary:

  • I wanted to add copy anyway
  • snapshot should be an option, on the server side with a query string, on the client side there should be copy and snapshot.
  • Try to use the pointers I gave to reuse existing functionality

I'm undecided whether we should allow this for mirror indexes. I currently lean towards forbidding it.

@gst gst force-pushed the enh-add-snapshot-feature branch from 55f3acf to 4f42341 Compare June 23, 2022 12:42
@fschulze
Copy link
Copy Markdown
Contributor

FYI, I rebased and squashed your branch at https://github.com/fschulze/devpi/tree/enh-add-snapshot-feature. I cherry picked some changes like the __repr__ stuff with some minor changes into main. I still didn't have time to take a deeper look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants