fix: sync Valentus FOUC paint-hold in head-meta override - #3
Open
AMDphreak wants to merge 2 commits into
Open
Conversation
Keeps DevCentr brand CSS inside the hold window pending upstream Default UI single-pass CSS. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Open
3 tasks
Add upgrade/sync guidance for adt-fouc-pending paint-hold in antora-ui-branding, activity log entry, and README/dark-mode notes for supplemental head-meta.hbs. Co-authored-by: Ryan Johnson <AMDphreak@users.noreply.github.com>
There was a problem hiding this comment.
Documentation review — FOUC paint-hold sync
Assessment: The code change correctly restores Valentus interim paint-hold ordering in head-meta.hbs. Documentation was missing upgrade guidance for this pattern.
Docs added/updated (commit 4d24777 on this branch)
| File | Change |
|---|---|
docs/modules/ROOT/pages/publishing/antora-ui-branding.adoc |
New FOUC paint-hold (interim) section: adt-fouc-pending load order, brand CSS placement, upgrade re-sync steps |
docs/modules/ROOT/pages/activity-log.adoc |
August 2026 entry for this fix |
README.adoc |
supplemental-ui/ row now mentions paint-hold + preference boot |
dark-mode-analysis.md |
Notes paint-hold + brand CSS ordering |
Codepaths covered
supplemental-ui/partials/head-meta.hbs— global paint-hold, layered CSS, dark-mode/read-width/font-size preference boot, release script- valentus-theme upgrade workflow for consumers of the DevCentr supplemental overlay
Knowledge gaps addressed
- Why the page hides briefly on load (interim until Default UI single-pass CSS)
- Where brand CSS must sit relative to paint-hold release (before release script, after valentus visual/read-width/font-size CSS)
- What to re-diff when bumping valentus-theme (upstream paint-hold block + DevCentr brand link)
Gaps not in scope for this PR
- No separate
changelog-details/structure in this repo — org usesactivity-log.adocinstead - README still lacks CI/CD badge (pre-existing; not introduced by this PR)
Sent by Cursor Automation: Generate docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adt-fouc-pendingpaint-hold so DevCentr brand / mermaid / math CSS does not reintroduce refresh settle.Test plan
Made with Cursor