Skip to content

fix(v2): output .noWait() as 'NOWAIT' - #108

Merged
servant-42 merged 2 commits into
datavjs:2.xfrom
joelmukuthu:2.x
Nov 6, 2018
Merged

fix(v2): output .noWait() as 'NOWAIT'#108
servant-42 merged 2 commits into
datavjs:2.xfrom
joelmukuthu:2.x

Conversation

@joelmukuthu

@joelmukuthu joelmukuthu commented Oct 28, 2018

Copy link
Copy Markdown
Contributor

Was previously output as 'NO WAIT'.

This applies the fix made in #106 to the v2 branch.

was previously output as 'NO WAIT'
@joelmukuthu

Copy link
Copy Markdown
Contributor Author

@prust any idea why the build is failing or how I can fix it?

@servant-42

Copy link
Copy Markdown
Collaborator

@joelmukuthu: Yes, the same thing happened on master recently and I fixed it in 67650011e30812b79243. It's because mocha doesn't support Node 4.x or earlier (and/or doesn't pin to dependencies that do).

I suppose that's technically fair, since Node 4.x ended its maintenance cycle in April, but it makes me feel like a grumpy old man (why are major platform versions only supported for a few years instead of a few decades?)

We'll need to update the .travis.yml file to match what's on master (Node 6.x & 8.x), even though SQLBricks still works fine on Node 4.x and 0.10.x and 0.12.x.

@joelmukuthu

Copy link
Copy Markdown
Contributor Author

Sorry for the late response. Haha, yeah the JS/Node community tends to move a bit too fast, which would not be a problem if only we'd support the old stuff a bit longer. Speaking of, how's it going with V3? :)

@servant-42
servant-42 merged commit d381b58 into datavjs:2.x Nov 6, 2018
@servant-42

Copy link
Copy Markdown
Collaborator

thanks @joelmukuthu, this is merged & deployed to npm as 2.0.4.

how's it going with V3

Well, I guess I don't move too fast :-) I'm going to need to carve out some time to move forward on v3. I do want to, and plan to, but it's a matter of making the time in my work day or in my afternoons/evenings, both of which are a bit tight at the moment.

@joelmukuthu

Copy link
Copy Markdown
Contributor Author

Great, thanks! Sounds good with the plan and I'm not blocked on anything so no rush. I'm looking forward to it all the same! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants