direct: refactor permissions objectIDRef into helper with if-elseif-else#5007
Open
janniklasrose wants to merge 3 commits intomainfrom
Open
direct: refactor permissions objectIDRef into helper with if-elseif-else#5007janniklasrose wants to merge 3 commits intomainfrom
janniklasrose wants to merge 3 commits intomainfrom
Conversation
Co-authored-by: Isaac
60b48f0 to
a7b7e79
Compare
denik
approved these changes
Apr 20, 2026
| func objectIDRef(prefix, baseNode string) string { | ||
| // Model serving endpoints use an internal numeric ID for permissions (not the name used in CRUD APIs). | ||
| if strings.HasPrefix(baseNode, "resources.model_serving_endpoints.") { | ||
| return prefix + "${" + baseNode + ".endpoint_id}" |
Contributor
There was a problem hiding this comment.
should it be a map perhaps? model_serving_endpoints -> endpoint_id, etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
objectIDRefhelper fromPreparePermissionsInputConfigto consolidate three sequential independentif strings.HasPrefixreassignments into a single if-elseif-else chain.Test plan
make test)This pull request and its description were written by Isaac.