Skip to content

Improve commands: alias, chain, reuse/recall - #28

Merged
wmathes merged 11 commits into
masterfrom
25-improve-cmds
Dec 2, 2017
Merged

Improve commands: alias, chain, reuse/recall#28
wmathes merged 11 commits into
masterfrom
25-improve-cmds

Conversation

@adhocore

@adhocore adhocore commented Nov 30, 2017

Copy link
Copy Markdown
Contributor

Closes #21
Closes #24
Closes #25

Given below configuration:

{
  "actions": {
    "multiple-cmd": {
      "command": ["echo multiple command as array", "@nested-cmd arg1 arg2"]
    },
    "nested-cmd": {
      "command": ["echo nested command %args%", "@deepnested-cmd --opt1 val1 --opt2 val2"]
    },
    "deepnested-cmd": {
      "command": ["echo deep nested command %args%"]
    },
    "host-cmd": {
      "service": "@host",
      "command": "docker-compose version"
    }
  }
}

when dopr multiple-cmd is run, it yields:

multiple command as array
nested command arg1 arg2
deep nested command --opt1 val1 --opt2 val2
docker-compose version 1.10.0, build 4bd6f1a
docker-py version: 2.0.1
CPython version: 2.7.9
OpenSSL version: OpenSSL 1.0.1t  3 May 2016

@wmathes wmathes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor doc issue ^^

Comment thread readme.md
"host-cmd": {
"service": "@host",
"command": "docker-compose version"
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good examples, wrong position :) you're editing the display of the default configuration ^^

@wmathes wmathes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'mon Jay :)

this is a publically viewable project. ^^ having the default configuration to get people started easier is a good habit. If you want to show the new features, add a separate block into the readme, but don't mistreat the existing part : )

@wmathes
wmathes merged commit e1c88e5 into master Dec 2, 2017
@wmathes
wmathes deleted the 25-improve-cmds branch December 2, 2017 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants