Token: allow the compiler to inline *At() calls#6479
Merged
chrchr-github merged 1 commit intocppcheck-opensource:mainfrom Jun 2, 2024
Merged
Token: allow the compiler to inline *At() calls#6479chrchr-github merged 1 commit intocppcheck-opensource:mainfrom
*At() calls#6479chrchr-github merged 1 commit intocppcheck-opensource:mainfrom
Conversation
Collaborator
Author
|
Clang 17 |
firewave
commented
Jun 1, 2024
| { | ||
| T *tok = thisTok->tokAt(index); | ||
| if (!tok) { | ||
| throw InternalError(thisTok, "Internal error. Token::linkAt called with index outside the tokens range."); |
Collaborator
Author
There was a problem hiding this comment.
I wonder if we should remove this and just let the code crash.
Collaborator
There was a problem hiding this comment.
Does it affect performance?
Collaborator
Author
There was a problem hiding this comment.
Technically it should because it can raise an exception (hence why noexcept is a thing).
In a short test:
Clang 17 1,194,021,239 -> 1,191,122,393
Collaborator
Author
|
callgrind in CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.