Skip to content

run selfchecks with rules/token-matching.xml#6477

Closed
firewave wants to merge 2 commits intocppcheck-opensource:mainfrom
firewave:selfcheck-rules
Closed

run selfchecks with rules/token-matching.xml#6477
firewave wants to merge 2 commits intocppcheck-opensource:mainfrom
firewave:selfcheck-rules

Conversation

@firewave
Copy link
Copy Markdown
Collaborator

@firewave firewave commented Jun 1, 2024

No description provided.

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Jun 1, 2024

Either the rules significantly slow down things or we had a big performance regression which slipped by me...

@firewave
Copy link
Copy Markdown
Collaborator Author

firewave commented Jun 3, 2024

@chrchr-github So what do we do with this now? IMO it would be nice if do not require a specially build binary to perform the internal checks. If we cannot (or are not) using the rules how do we expect the user to.

@chrchr-github
Copy link
Copy Markdown
Collaborator

I guess it was intended to allow developers to check their code without having the CHECK_INTERNAL flag set. But the CI does that anyway.
@orbitcowboy Do you actually use this rule file?

@orbitcowboy
Copy link
Copy Markdown
Collaborator

I guess it was intended to allow developers to check their code without having the CHECK_INTERNAL flag set. But the CI does that anyway. @orbitcowboy Do you actually use this rule file?
Thanks for asking! Since CI does it anyway, I have no special local use case.

@chrchr-github
Copy link
Copy Markdown
Collaborator

So I would say we should get rid of it.

@firewave
Copy link
Copy Markdown
Collaborator Author

error-reporting.xml can also be removed.

The remaining ones might also be obsolete or should be used in the selfchecks. Even if those are meant to be examples they should at least be tested.

@firewave firewave marked this pull request as draft July 29, 2024 06:34
@firewave
Copy link
Copy Markdown
Collaborator Author

Closed in favor of #6951.

@firewave firewave closed this Oct 24, 2024
@firewave firewave deleted the selfcheck-rules branch October 24, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants