bail out on invalid MATCHCOMPILER (make) and USE_MATCHCOMPILER (CMake) values / Makefile: removed deprecated SRCDIR#6021
Merged
orbitcowboy merged 3 commits intocppcheck-opensource:mainfrom Feb 25, 2024
Conversation
c72578
reviewed
Apr 25, 2024
|
|
||
| set(USE_MATCHCOMPILER "Auto" CACHE STRING "Usage of match compiler") | ||
| set_property(CACHE USE_MATCHCOMPILER PROPERTY STRINGS Auto Off On Verify) | ||
| set(_MATCHCOMPILER_STRINGS Auto Off On Verify) |
Contributor
There was a problem hiding this comment.
According to readme.md this should be "ON" in capital letters. Same for "OFF".
Otherwise:
CMake Error at cmake/options.cmake:28 (message):
Invalid USE_MATCHCOMPILER value 'ON'
Collaborator
Author
There was a problem hiding this comment.
The change was faulty - see also #6321.
I will post a PR fixing this tomorrow and mark it for backport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally specified
MATCHCOMPILER=1and only later realized that the matchcompiler was not being used as it requiresyesinstead. So bail out on this.