removed ErrorLogger::reportProgress() and command-line option --report-progress#5269
removed ErrorLogger::reportProgress() and command-line option --report-progress#5269firewave wants to merge 1 commit intocppcheck-opensource:mainfrom
ErrorLogger::reportProgress() and command-line option --report-progress#5269Conversation
|
As a fix for the democlient it should possibly perform a delayed call to I am also open to keeping the option and nop'ing it for now and provide a much better progress implementation later on. |
|
This approach goes probably a bit too far. I will revise the changes. |
|
as I said.. we have reasons to keep this. maybe you can consider using the reportProgress instead. |
|
Yes, this goes in hand with #5288 and https://trac.cppcheck.net/ticket/11248 as it is about progress indication as well as providing interruption points for cancellation (especially if not using threads instead of processes). Maybe this could even be addressed with the current executor rework I am doing. |
|
I will file a ticket about this in the next few days. |
|
Seems there already was a ticket about this: https://trac.cppcheck.net/ticket/3450. I also came to some of the same conclusions before even reading it. |
As detailed in #4985 (comment) it doesn't provide much progress and adds unnecessary complexity to the
ErrorLoggerandCppcheckExecutor.We should probably remove
TokenImpl::mProgressValueas well.