astutils.h: reserve std::vector space in visitAstNodes() to avoid excess allocations#4158
Merged
danmar merged 1 commit intocppcheck-opensource:mainfrom Jun 3, 2022
Merged
Conversation
… excess allocations
std::vector space in visitAstNodes() to avoid excess allocations
This was referenced May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an intermediate solution until
SmallVectoris able to avoid these allocation when not utilizing Boost. As it already provides a sizable improvement without the need for any external dependency I decided to go with this for now.Testing an
-O2build with--enable=all --inconclusiveonmame_regtestcode (with some additional local speed hacks applied):GCC 11
37,875,483,481->33,842,501,109Clang 13
35,459,791,724->28,694,901,787