[virtual-machine] Add support for various storages - #974
Conversation
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
WalkthroughThis update revises the version mapping and Helm chart metadata for the "virtual-machine" application, incrementing its version to 0.9.2. It also modifies the data volume template in the VM's deployment manifest, replacing the explicit PVC definition with a more generic storage specification. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HelmChart
participant Kubernetes
participant DataVolume
User->>HelmChart: Deploy virtual-machine 0.9.2
HelmChart->>Kubernetes: Apply vm.yaml manifest
Kubernetes->>DataVolume: Create DataVolume with storage spec
DataVolume-->>Kubernetes: Provision storage (no explicit PVC block)
Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
packages/apps/virtual-machine/templates/vm.yaml (1)
30-36:⚠️ Potential issueCritical: Use
pvcinstead of unsupportedstoragein DataVolumeTemplates.
ThedataVolumeTemplatessection for KubeVirt relies on the CDI DataVolume spec, which expects apvcblock underspec, notstorage. As written, this will fail CRD validation during deployment.Apply this diff to restore the correct field name:
-spec: - storage: +spec: + pvc: resources: requests: storage: {{ .Values.systemDisk.storage | quote }} {{- with .Values.systemDisk.storageClass }} storageClassName: {{ . }} {{- end }}
🧹 Nitpick comments (1)
packages/apps/virtual-machine/Chart.yaml (1)
26-26: Update appVersion to 0.9.2.
The application version aligns with the chart bump. Consider quotingappVersion(e.g.,"0.9.2") as recommended by Helm to ensure it’s treated as a string and avoid YAML parsing issues.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/apps/versions_map(1 hunks)packages/apps/virtual-machine/Chart.yaml(1 hunks)packages/apps/virtual-machine/templates/vm.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build and Test
🔇 Additional comments (2)
packages/apps/virtual-machine/Chart.yaml (1)
20-20: Bump chart version to 0.9.2.
Theversionfield has been correctly incremented to reflect changes in the chart and its templates.packages/apps/versions_map (1)
160-161: Pin old version and add new virtual-machine entry.
Mappingvirtual-machine 0.9.1to a specific commit and introducingvirtual-machine 0.9.2atHEADensures reproducible builds and aligns with the chart bump.
remove specification:
with
storageit will be filled automatcially from storageprofile for specific storage providerSummary by CodeRabbit