Skip to content

[build] system/metallb: multiarch support - #970

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
metallb-multiarch-image
May 24, 2025
Merged

[build] system/metallb: multiarch support#970
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
metallb-multiarch-image

Conversation

@nbykov0

@nbykov0 Nikita (nbykov0) commented May 21, 2025 •
edited by NickVolynkin
Loading

Copy link
Copy Markdown
Collaborator

Add support for metallb multiarch build.

Part of #519 and a follow-up to PR #945 (issue #909)

Summary by CodeRabbit

  • Chores
    • Improved Docker build process for image-controller and image-speaker to allow dynamic control over image loading and enhanced build configuration consistency. No changes to user-facing features.

@nbykov0
system/metallb: multiarch support
5407ee0 
Signed-off-by: nbykov0 <166552198+nbykov0@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented May 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The Makefile for MetalLB was updated to enhance the Docker build commands for the image-controller and image-speaker targets. This includes specifying builder and platform options, making the image loading behavior configurable, and adjusting command formatting for consistency.

Changes

File(s) Change Summary
packages/system/metallb/Makefile Enhanced Docker build commands: added --builder and --platform options, made --load flag configurable, and reformatted --label usage.

Possibly related PRs

Suggested labels

ok-to-test

Poem

A bunny hopped by the Makefile’s line,
Tweaked the build with flags so fine.
Now platforms and builders are set with care,
And loading images is handled fair.
With Docker commands neat and new,
This rabbit says, “Great job to you!” 🐇

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nbykov0
Nikita (nbykov0) marked this pull request as ready for review May 21, 2025 23:50
@nbykov0 Nikita (nbykov0) self-assigned this May 21, 2025
coderabbitai[bot]
coderabbitai Bot reviewed May 21, 2025
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/system/metallb/Makefile (1)

19-20: Ensure variables for multi-arch support are defined or documented.
The addition of --builder=$(BUILDER) and --platform=$(PLATFORM) is essential for multi-architecture builds. Please confirm that BUILDER and PLATFORM have sensible defaults (either in this Makefile or in common-envs.mk) and are documented for consumers.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 609e7ed and 5407ee0.

📒 Files selected for processing (1)
  • packages/system/metallb/Makefile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build and Test
🔇 Additional comments (2)
packages/system/metallb/Makefile (2)

28-28: Consistent labeling format applied.
Moving the --label flag onto one line with the trailing backslash aligns with the surrounding flags and improves readability.

29-29: Verify compatibility of --load with --push.
Specifying --load=$(LOAD) alongside --push=$(PUSH) can cause buildx to error in some versions. Please verify that your build environment supports both flags simultaneously, or consider conditional logic to pass only one.

@NickVolynkin Nick Volynkin (NickVolynkin) changed the title system/metallb: multiarch support [build] system/metallb: multiarch support May 23, 2025
kvaps
Andrei Kvapil (kvaps) approved these changes May 24, 2025
View reviewed changes

@kvaps Andrei Kvapil (kvaps) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvaps
Andrei Kvapil (kvaps) merged commit d497be9 into main May 24, 2025
@kvaps
Andrei Kvapil (kvaps) deleted the metallb-multiarch-image branch May 24, 2025 20:31
@coderabbitai coderabbitai Bot mentioned this pull request May 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@kvaps Andrei Kvapil (kvaps) kvaps approved these changes
@lllamnyp Timofei Larkin (lllamnyp) Awaiting requested review from lllamnyp lllamnyp is a code owner
@klinch0 klinch0 Awaiting requested review from klinch0

Assignees

@lllamnyp Timofei Larkin (lllamnyp)

@nbykov0 Nikita (nbykov0)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nbykov0 @kvaps @NickVolynkin @lllamnyp