fix: missing package-system.mk - #96
Merged
Merged
Conversation
Andrei Kvapil (kvaps)
marked this pull request as draft
April 23, 2024 07:38
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Andrei Kvapil (kvaps)
marked this pull request as ready for review
April 23, 2024 07:43
Marian Koreniuk (themoriarti)
approved these changes
Apr 23, 2024
Marian Koreniuk (themoriarti)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
|
|
||
| suspend: ## Suspend reconciliation for an existing Helm release | ||
| flux suspend hr -n $(NAMESPACE) $(NAME) | ||
| kubectl patch hr -n $(NAMESPACE) $(NAME) -p '{"spec": {"suspend": true}}' --type=merge |
There was a problem hiding this comment.
Flux does not tolerate kubectl edits https://fluxcd.io/flux/faq/#why-are-kubectl-edits-rolled-back-by-flux
Member
Author
There was a problem hiding this comment.
Stefan Prodan (@stefanprodan) thank you for your note! I just added PR for fixing this #101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix regression introduced by #86
and