[kubernetes] Update Kubernetes v1.32.4 - #949
Conversation
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
WalkthroughThe changes update the Kubernetes application's Helm chart by increasing the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Helm
participant Kubernetes Cluster
User->>Helm: Install/Upgrade chart (with appVersion 1.32.4)
Helm->>Kubernetes Cluster: Render templates (using appVersion)
Kubernetes Cluster->>Kubernetes Cluster: Deploy resources with version fields set to 1.32.4
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/apps/kubernetes/Chart.yaml (1)
25-25: Consider bumping the chart version
You’ve updatedappVersionto 1.32.4, which is critical for deployments. Best practice is to increment the chart’sversionfield (e.g., from 0.20.0 → 0.20.1) whenever you changeappVersionor any templates, ensuring proper versioning and avoiding package conflicts.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (2)
packages/apps/kubernetes/Chart.yaml(1 hunks)packages/apps/kubernetes/templates/cluster.yaml(2 hunks)
🔇 Additional comments (2)
packages/apps/kubernetes/templates/cluster.yaml (2)
160-160: Leverage dynamicAppVersionfor control‐plane
Replacing the hardcoded"1.30.1"with{{ $.Chart.AppVersion }}makes theKamajiControlPlanespec version automatically track the chart’sappVersion. This improves maintainability and reduces drift between your Chart and deployed cluster.
286-286: Leverage dynamicAppVersionfor worker nodes
Updating theMachineDeploymentspecversiontov{{ $.Chart.AppVersion }}ensures worker nodes use the same Kubernetes version as specified by your chart, eliminating manual updates. Nice work!
Signed-off-by: Andrei Kvapil <kvapss@gmail.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated the application version in the Kubernetes chart to 1.32.4. - Made version fields in Kubernetes cluster templates dynamically reference the chart's application version, ensuring consistency during deployments. <!-- end of auto-generated comment: release notes by coderabbit.ai --> (cherry picked from commit dd592ca) Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
Signed-off-by: Andrei Kvapil kvapss@gmail.com
Summary by CodeRabbit