Skip to content

[cluster-api] Update operator, providers, remove Kamaji workaround - #867

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
kamaji-capi
Apr 24, 2025
Merged

[cluster-api] Update operator, providers, remove Kamaji workaround#867
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
kamaji-capi

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented Apr 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  • Update Cluster API operator to v0.19.0
  • Update Cluster API Kamaji control-plane provider to v0.14.2.
    • This change includes upstream fix, so our workaround get removed
  • Update Cluster API KubeVirt infrastructure provider to v0.1.10
  • Update Cluster API core provider to v1.10.0
  • Update Cluster API kubeadm config provider to v1.10.0

Signed-off-by: Andrei Kvapil kvapss@gmail.com

@coderabbitai

coderabbitai Bot commented Apr 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

Andrei Kvapil (@kvaps) has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 7 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 07d7fad and b56624a.

📒 Files selected for processing (12)
  • packages/system/capi-operator/charts/cluster-api-operator/Chart.yaml (1 hunks)
  • packages/system/capi-operator/charts/cluster-api-operator/templates/addon.yaml (2 hunks)
  • packages/system/capi-operator/charts/cluster-api-operator/templates/bootstrap.yaml (2 hunks)
  • packages/system/capi-operator/charts/cluster-api-operator/templates/control-plane.yaml (2 hunks)
  • packages/system/capi-operator/charts/cluster-api-operator/templates/core.yaml (2 hunks)
  • packages/system/capi-operator/charts/cluster-api-operator/templates/infra.yaml (2 hunks)
  • packages/system/capi-operator/charts/cluster-api-operator/templates/ipam.yaml (2 hunks)
  • packages/system/capi-operator/charts/cluster-api-operator/templates/operator-components.yaml (36 hunks)
  • packages/system/capi-operator/charts/cluster-api-operator/values.schema.json (1 hunks)
  • packages/system/capi-operator/charts/cluster-api-operator/values.yaml (2 hunks)
  • packages/system/capi-providers/templates/providers.yaml (2 hunks)
  • packages/system/kamaji/images/kamaji/patches/hardcode-port.diff (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps
[cluster-api] Update operator, providers, remove Kamaji workaround
b56624a 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps Andrei Kvapil (kvaps) changed the title [cluster-api] Update providers, remove Kamaji workaround [cluster-api] Update operator, providers, remove Kamaji workaround Apr 23, 2025
@kvaps
Andrei Kvapil (kvaps) merged commit b895ccf into main Apr 24, 2025
@kvaps
Andrei Kvapil (kvaps) deleted the kamaji-capi branch April 24, 2025 11:30
@kvaps Andrei Kvapil (kvaps) mentioned this pull request May 16, 2025
Merged
Andrei Kvapil (kvaps) added a commit that referenced this pull request May 17, 2025
@kvaps
[kubernetes] fix regression: return port specification (#956)
fb26e3e 
This PR fixes regression from
#867

We have updated Kamaji, removed workaround, but didn't return the port
specification

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated network configuration to explicitly include port 443 in
hostnames for ingress.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Timofei Larkin (lllamnyp) pushed a commit that referenced this pull request May 20, 2025
@kvaps @lllamnyp
[kubernetes] fix regression: return port specification (#956)
ed68379 
This PR fixes regression from
#867

We have updated Kamaji, removed workaround, but didn't return the port
specification

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Refactor**
- Updated network configuration to explicitly include port 443 in
hostnames for ingress.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

(cherry picked from commit fb26e3e)
Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lllamnyp Timofei Larkin (lllamnyp) lllamnyp approved these changes
@klinch0 klinch0 Awaiting requested review from klinch0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kvaps @lllamnyp