[kubernetes] Fix tenant addons removal by kvaps · Pull Request #835 · cozystack/cozystack

Andrei Kvapil (kvaps) · 2025-04-22T09:42:47Z

Signed-off-by: Andrei Kvapil kvapss@gmail.com

Summary by CodeRabbit

New Features
- Expanded the pre-delete operation to target additional components, including cert-manager and vertical pod autoscaler resources.
Chores
- Updated chart version to 0.18.1 and revised version mappings for improved tracking.

Backported to v0.30 in #852

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

coderabbitai · 2025-04-22T09:42:53Z

Walkthrough

This update increments the Kubernetes chart version from 0.18.0 to 0.18.1 and updates version mappings accordingly. It expands the pre-delete HelmRelease job to include three additional HelmRelease resources—cert-manager-crds, vertical-pod-autoscaler, and vertical-pod-autoscaler-crds—in both the targeted patch command and the RBAC permissions. No changes were made to exported or public entity declarations.

Changes

File(s)	Change Summary
packages/apps/kubernetes/Chart.yaml	Chart version bumped from 0.18.0 to 0.18.1.
packages/apps/kubernetes/templates/helmreleases/delete.yaml	Added three HelmRelease resource names to pre-delete job and expanded RBAC resourceNames accordingly.
packages/apps/versions_map	Updated version mapping: 0.18.0 now points to a commit hash; added 0.18.1 pointing to HEAD.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PreDeleteJob
    participant KubernetesAPI

    User->>PreDeleteJob: Initiate pre-delete job
    PreDeleteJob->>KubernetesAPI: Patch HelmRelease "cert-manager"
    PreDeleteJob->>KubernetesAPI: Patch HelmRelease "cert-manager-crds"
    PreDeleteJob->>KubernetesAPI: Patch HelmRelease "vertical-pod-autoscaler"
    PreDeleteJob->>KubernetesAPI: Patch HelmRelease "vertical-pod-autoscaler-crds"
    PreDeleteJob->>KubernetesAPI: Patch other existing HelmReleases

Possibly related PRs

[monitoring] add vpa for users k8s clusters #806: Introduces the vertical pod autoscaler HelmRelease configurations and chart version 0.18.0, which the current PR builds upon by expanding deletion handling for these resources.

Suggested labels

ok-to-test

Suggested reviewers

lllamnyp

Poem

A hop, a skip, a chart update bright,
New releases join the pre-delete flight.
Autoscalers and CRDs now in the fold,
With version bumps, the story is told.
The rabbit cheers, “The cluster’s in tune!”
🐇✨ Chart 0.18.1—deploying soon!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a14bcf9 and 1d0ee15.

📒 Files selected for processing (3)

packages/apps/kubernetes/Chart.yaml (1 hunks)
packages/apps/kubernetes/templates/helmreleases/delete.yaml (2 hunks)
packages/apps/versions_map (1 hunks)

🔇 Additional comments (4)

packages/apps/kubernetes/Chart.yaml (1)

19-19: Helm chart version bump to 0.18.1
Chart version increment looks correct and aligns with the PR objective. Please ensure any accompanying Chart.lock or dependency updates are generated and committed (e.g., via helm dependency update).

packages/apps/versions_map (1)

61-62: Pin kubernetes 0.18.0 and add mapping for 0.18.1
The change correctly anchors 0.18.0 to commit 721c12a7 and introduces 0.18.1 pointing at HEAD. This keeps the versions_map in sync with the chart bump.

packages/apps/kubernetes/templates/helmreleases/delete.yaml (2)

35-37: Include new HelmRelease resources in pre-delete patch
The additions of cert-manager-crds, vertical-pod-autoscaler, and vertical-pod-autoscaler-crds to the kubectl patch command satisfy the tenant addons removal fix.

73-75: Grant RBAC patch permission for new HelmReleases
Updated the Role’s resourceNames block to cover the newly added HelmRelease CRDs and autoscaler resources—this aligns with the expanded pre-delete job scope.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Backport of #835 **New Features** - Expanded the pre-delete operation to target additional components, including cert-manager and vertical pod autoscaler resources. **Chores** - Updated chart version to 0.18.1 and revised version mappings for improved tracking. (cherry picked from commit ccedcb7) Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Backport of #835 **New Features** - Expanded the pre-delete operation to target additional components, including cert-manager and vertical pod autoscaler resources. **Chores** - Updated chart version to 0.18.1 and revised version mappings for improved tracking. (cherry picked from commit ccedcb7) Co-authored-by: Andrei Kvapil <kvapss@gmail.com> Signed-off-by: Nick Volynkin <nick.volynkin@gmail.com>

[kubernetes] Fix tenant addons removal

1d0ee15

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Andrei Kvapil (kvaps) requested a review from Timofei Larkin (lllamnyp) as a code owner April 22, 2025 09:42

Andrei Kvapil (kvaps) requested a review from klinch0 April 22, 2025 09:42

klinch0 approved these changes Apr 22, 2025

View reviewed changes

Andrei Kvapil (kvaps) added the backport Should change be backported on previous release label Apr 22, 2025

Timofei Larkin (lllamnyp) approved these changes Apr 22, 2025

View reviewed changes

klinch0 merged commit ccedcb7 into main Apr 22, 2025

klinch0 deleted the fix-kubernetes-delete-hr branch April 22, 2025 13:07

coderabbitai Bot mentioned this pull request Nov 6, 2025

[kubernetes] Helm hooks for cleanup #1606

Merged

Navigation Menu

Uh oh!

[kubernetes] Fix tenant addons removal - #835

[kubernetes] Fix tenant addons removal#835
klinch0 merged 1 commit into
mainfrom
fix-kubernetes-delete-hr

Andrei Kvapil (kvaps) commented Apr 22, 2025 •

edited by NickVolynkin

Loading

Uh oh!

coderabbitai Bot commented Apr 22, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Andrei Kvapil (kvaps) commented Apr 22, 2025 • edited by NickVolynkin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Andrei Kvapil (kvaps) commented Apr 22, 2025 •

edited by NickVolynkin

Loading

coderabbitai Bot commented Apr 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)