Skip to content

Fix: versions_map, include only versions from tags - #777

Merged
klinch0 merged 1 commit into
mainfrom
fix-versions-map
Apr 9, 2025
Merged

Fix: versions_map, include only versions from tags#777
klinch0 merged 1 commit into
mainfrom
fix-versions-map

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented Apr 9, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Andrei Kvapil kvapss@gmail.com

Summary by CodeRabbit

  • Bug Fixes

    • Improved error handling so that missing chart versions no longer halt processing, ensuring smoother operations.

  • Chores

    • Simplified the version tag lookup to rely solely on remote repository tags for increased consistency and reliability.
    • Updated the Kafka application version from 0.5.0 to 0.5.2.
    • Adjusted versioning information for the Kafka package to reflect fixed commit references.
    • Streamlined the pre-commit workflow by removing unnecessary steps and logging.

@coderabbitai

coderabbitai Bot commented Apr 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

klinch0 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 40 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between bdf0b11 and 3c3b1a3.

📒 Files selected for processing (1)
  • .github/workflows/pre-commit.yml (1 hunks)

Walkthrough

The pull request updates the version map generation script by removing the use of the latest main branch commit when searching for version tags, thereby limiting the search to tags available from the remote repository. The error handling logic is also modified: if a chart version is not found, the script now removes that chart version from consideration and continues processing, rather than terminating execution. Additionally, the version number for the Kafka application is updated from 0.5.0 to 0.5.2, and the versioning information in the versions map is adjusted accordingly.

Changes

File Change Summary
hack/gen_versions_map.sh Removed latest main commit from version tag search; modified error handling to remove chart version from processing instead of exiting on failure.
packages/apps/kafka/Chart.yaml Updated version number from 0.5.0 to 0.5.2.
packages/apps/versions_map Updated version entry for kafka 0.5.0 from HEAD to commit hash de19450f; added new version entry for kafka 0.5.2 pointing to HEAD.
.github/workflows/pre-commit.yml Removed logging statements for files in the pre-commit hooks step; retained logic for determining files variable.

Possibly related PRs

  • fix version map #776: The changes in the main PR regarding the versions_map file are related to the modifications in the retrieved PR, as both involve updating version entries and transitioning from HEAD references to specific commit hashes for versioning.

Suggested reviewers

  • lllamnyp
  • kvaps

Poem

I’m a rabbit with a code delight,
Hopping through changes in the night.
No commit from main in my sight,
Skipping errors without a fright.
Processing smoothly with each byte! 🐰✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps
Fix: versions_map, include only versions from tags
1721d39 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
coderabbitai[bot]
coderabbitai Bot reviewed Apr 9, 2025
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/workflows/pre-commit.yml (2)

41-41: Debug Logging: Outputting base_commit Value
The newly added echo $base_commit is useful for debugging and verifying that the base_commit is correctly determined from the remote branch. Consider using conditional logging (or a debug flag) for production environments to avoid unnecessary log clutter.

47-47: Debug Logging: Outputting files Value
Adding echo $files helps confirm which files are being targeted by the pre-commit hook. Similar to the previous comment, consider gating this logging behind a debug flag to keep production logs clean.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5672814 and 8e704dc.

📒 Files selected for processing (1)
  • .github/workflows/pre-commit.yml (1 hunks)

@klinch0
klinch0 force-pushed the fix-versions-map branch 5 times, most recently from 3ef5f6c to bdf0b11 Compare April 9, 2025 15:34
coderabbitai[bot]
coderabbitai Bot reviewed Apr 9, 2025
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/pre-commit.yml (1)

12-12: Self-hosted Runner Configuration Change

The change to runs-on: [self-hosted] indicates a shift from using a fixed cloud runner (like ubuntu-22.04) to relying on a self-hosted environment. Ensure that the self-hosted runner is properly configured and has all the necessary dependencies (e.g., Git, pre-commit, any language runtimes) installed, as the previously removed setup steps (for Python and Node.js) might not be available by default.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90f159d and bdf0b11.

📒 Files selected for processing (1)
  • .github/workflows/pre-commit.yml (1 hunks)

@klinch0
klinch0 force-pushed the fix-versions-map branch 2 times, most recently from 3c3b1a3 to 1721d39 Compare April 9, 2025 15:39
@klinch0
klinch0 merged commit c844a4f into main Apr 9, 2025
@klinch0
klinch0 deleted the fix-versions-map branch April 9, 2025 15:47
@coderabbitai coderabbitai Bot mentioned this pull request Apr 9, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Apr 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@lllamnyp Timofei Larkin (lllamnyp) Awaiting requested review from lllamnyp lllamnyp is a code owner
+1 more reviewer
@klinch0 klinch0 klinch0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kvaps @klinch0