Skip to content

Kubernetes: fix namespace for KubevirtMachineTemplate - #673

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
KubevirtMachineTemplate
Mar 5, 2025
Merged

Kubernetes: fix namespace for KubevirtMachineTemplate#673
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
KubevirtMachineTemplate

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented Mar 5, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Bumped the Kubernetes application chart version from 0.15.1 to 0.15.2.
    • Updated version tracking details to ensure accurate reference points.
  • New Features
    • Improved the deployment configuration by enabling dynamic namespace assignment based on the release environment.

@dosubot dosubot Bot added the size/XS This PR changes 0-9 lines, ignoring generated files label Mar 5, 2025
@coderabbitai

coderabbitai Bot commented Mar 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

This PR updates the Kubernetes chart by incrementing the chart version in Chart.yaml from 0.15.1 to 0.15.2. It also modifies the deployment template in cluster.yaml to use a dynamic namespace reference ({{ $.Release.Namespace }}) instead of the static value default. Additionally, the versions_map file is updated by replacing the floating commit reference for version 0.15.1 with a fixed commit hash and adding a new version entry for 0.15.2 with a HEAD reference.

Changes

File(s) Changed Summary of Changes
packages/apps/kubernetes/Chart.yaml, packages/apps/versions_map Updated chart version from 0.15.1 to 0.15.2 in Chart.yaml; in versions_map, replaced HEAD for 0.15.1 with commit 77df31e1 and added a new entry for 0.15.2 with HEAD.
packages/apps/kubernetes/templates/cluster.yaml Replaced the static namespace (default) with a dynamic reference ({{ $.Release.Namespace }}) in the KubevirtMachineTemplate within the MachineDeployment.

Possibly related PRs

  • fix-vm-logs-url #538: Updates the version number in the Chart.yaml file for the monitoring application, representing a similar type of version update.

Suggested labels

enhancement, size:S, lgtm

Suggested reviewers

  • klinch0

Poem

Little hops through lines of code,
A tiny rabbit on a version road.
From static defaults to dynamic flair,
A commit here, a change there.
Celebrate each update with a joyful beat,
CodeRabbit's cheer makes our pull request sweet! 🐰💻

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43e593c and 1877f17.

📒 Files selected for processing (3)
  • packages/apps/kubernetes/Chart.yaml (1 hunks)
  • packages/apps/kubernetes/templates/cluster.yaml (1 hunks)
  • packages/apps/versions_map (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/apps/kubernetes/Chart.yaml
🔇 Additional comments (2)
packages/apps/versions_map (1)

51-52: Version management looks good!

The changes properly update the version mapping:

  1. Pinning version 0.15.1 to a specific commit (77df31e)
  2. Adding the new 0.15.2 version with HEAD reference

This follows the standard pattern for version increments in the project.

packages/apps/kubernetes/templates/cluster.yaml (1)

253-253: Good fix to use dynamic namespace reference!

This change correctly replaces the hardcoded namespace default with a dynamic reference to {{ $.Release.Namespace }} for the KubevirtMachineTemplate. This aligns with the PR objective and makes the chart more flexible by using the namespace where the Helm chart is deployed.

This also brings consistency with other namespace references in the template, as seen in lines 75, 85, 93, 99, 134, 151, 158, 200, 217, 247, 260, and 280 where {{ $.Release.Namespace }} is already used.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps
Kubernetes: fix namespace for KubevirtMachineTemplate
1877f17 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@dosubot dosubot Bot added the kind/bug Categorizes issue or PR as related to a bug label Mar 5, 2025
@kvaps
Andrei Kvapil (kvaps) merged commit 485b1df into main Mar 5, 2025
@kvaps
Andrei Kvapil (kvaps) deleted the KubevirtMachineTemplate branch March 5, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lllamnyp Timofei Larkin (lllamnyp) Awaiting requested review from lllamnyp lllamnyp is a code owner

Assignees

No one assigned

Labels

kind/bug Categorizes issue or PR as related to a bug size/XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kvaps