Skip to content

Update fluxcd-operator to 0.13.0 - #586

Merged
Andrei Kvapil (kvaps) merged 1 commit into
cozystack:mainfrom
kingdonb:update-flux
Jan 17, 2025
Merged

Update fluxcd-operator to 0.13.0#586
Andrei Kvapil (kvaps) merged 1 commit into
cozystack:mainfrom
kingdonb:update-flux

Conversation

@kingdonb

@kingdonb Kingdon Barrett (kingdonb) commented Jan 16, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Added support for common metadata (annotations and labels) in Flux instance configuration
    • Introduced a name field for sync configuration in Flux instance

  • Version Updates

    • Upgraded Flux Operator chart from v0.12.0 to v0.13.0
    • Upgraded Flux Instance chart from v0.12.0 to v0.13.0

@kingdonb
Update fluxcd-operator, flux-instance charts
ad42e4b 
Signed-off-by: Kingdon B <kingdon@urmanac.com>
@coderabbitai

coderabbitai Bot commented Jan 16, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

This pull request introduces version updates and configuration enhancements for the Flux Operator and Flux Instance Helm charts. The changes primarily involve incrementing the version numbers from v0.12.0 to v0.13.0 across multiple configuration files. Additionally, the Flux Instance chart gains new configuration capabilities, including a commonMetadata section for annotations and labels, and a name field in the sync configuration.

Changes

File Change Summary
packages/system/fluxcd-operator/charts/flux-operator/Chart.yaml Version bumped from 0.12.0 to 0.13.0
packages/system/fluxcd-operator/charts/flux-operator/README.md Version badges updated to 0.13.0
packages/system/fluxcd/charts/flux-instance/Chart.yaml Version and app version bumped from 0.12.0 to 0.13.0
packages/system/fluxcd/charts/flux-instance/README.md Version badges updated, sync object key modified
packages/system/fluxcd/charts/flux-instance/templates/instance.yaml Added commonMetadata and name fields
packages/system/fluxcd/charts/flux-instance/values.schema.json Added schema for commonMetadata and sync.name
packages/system/fluxcd/charts/flux-instance/values.yaml Added commonMetadata and sync.name configuration options

Possibly related PRs

Suggested Labels

enhancement, size:M, documentation

Suggested Reviewers

  • kvaps

Poem

🐰 Flux of versions, dancing light,
Metadata blooming, charts take flight!
From zero-twelve to zero-thirteen,
A rabbit's upgrade, sleek and clean!
Synchronize with joy and might! 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai Bot reviewed Jan 16, 2025
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/system/fluxcd/charts/flux-instance/README.md (1)

41-47: Fix bare URLs in documentation.

The URLs in the documentation should be properly formatted as markdown links.

Replace bare URLs with properly formatted markdown links:

-| instance.commonMetadata | object | `{"annotations":{},"labels":{}}` | Common metadata https://fluxcd.control-plane.io/operator/fluxinstance/#common-metadata |
+| instance.commonMetadata | object | `{"annotations":{},"labels":{}}` | Common metadata [documentation](https://fluxcd.control-plane.io/operator/fluxinstance/#common-metadata) |
🧰 Tools
🪛 Markdownlint (0.37.0)

41-41: null
Bare URL used

(MD034, no-bare-urls)

42-42: null
Bare URL used

(MD034, no-bare-urls)

43-43: null
Bare URL used

(MD034, no-bare-urls)

44-44: null
Bare URL used

(MD034, no-bare-urls)

45-45: null
Bare URL used

(MD034, no-bare-urls)

46-46: null
Bare URL used

(MD034, no-bare-urls)

47-47: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4e68e65 and ad42e4b.

📒 Files selected for processing (7)
  • packages/system/fluxcd-operator/charts/flux-operator/Chart.yaml (2 hunks)
  • packages/system/fluxcd-operator/charts/flux-operator/README.md (1 hunks)
  • packages/system/fluxcd/charts/flux-instance/Chart.yaml (2 hunks)
  • packages/system/fluxcd/charts/flux-instance/README.md (2 hunks)
  • packages/system/fluxcd/charts/flux-instance/templates/instance.yaml (1 hunks)
  • packages/system/fluxcd/charts/flux-instance/values.schema.json (2 hunks)
  • packages/system/fluxcd/charts/flux-instance/values.yaml (2 hunks)
✅ Files skipped from review due to trivial changes (3)
  • packages/system/fluxcd-operator/charts/flux-operator/README.md
  • packages/system/fluxcd/charts/flux-instance/Chart.yaml
  • packages/system/fluxcd-operator/charts/flux-operator/Chart.yaml
🧰 Additional context used
🪛 Markdownlint (0.37.0)
packages/system/fluxcd/charts/flux-instance/README.md

41-41: null
Bare URL used

(MD034, no-bare-urls)

42-42: null
Bare URL used

(MD034, no-bare-urls)

43-43: null
Bare URL used

(MD034, no-bare-urls)

44-44: null
Bare URL used

(MD034, no-bare-urls)

45-45: null
Bare URL used

(MD034, no-bare-urls)

46-46: null
Bare URL used

(MD034, no-bare-urls)

47-47: null
Bare URL used

(MD034, no-bare-urls)

🔇 Additional comments (5)
packages/system/fluxcd/charts/flux-instance/templates/instance.yaml (2)

25-35: Well-structured implementation of commonMetadata section!

The conditional inclusion and proper YAML indentation ensure clean metadata handling.

43-45: Clean implementation of the sync name field!

The conditional inclusion is properly implemented and maintains consistency with the existing sync configuration structure.

packages/system/fluxcd/charts/flux-instance/values.yaml (1)

26-29: Well-documented configuration with appropriate defaults!

The implementation includes:

  • Clear documentation links
  • Proper schema annotations
  • Appropriate default values

Also applies to: 45-45

packages/system/fluxcd/charts/flux-instance/README.md (1)

3-3: Version updates are consistent!

The version badges correctly reflect the upgrade to 0.13.0.

packages/system/fluxcd/charts/flux-instance/values.schema.json (1)

44-56: Schema definitions are properly implemented!

The schema correctly defines:

  • commonMetadata structure with annotations and labels
  • name field in sync configuration

Also applies to: 139-141

@dosubot dosubot Bot added size/M This PR changes 30-99 lines, ignoring generated files kind/documentation Categorizes issue or PR as related to documentation kind/feature Categorizes issue or PR as related to a new feature labels Jan 16, 2025
kvaps
Andrei Kvapil (kvaps) approved these changes Jan 17, 2025
View reviewed changes

@kvaps Andrei Kvapil (kvaps) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvaps
Andrei Kvapil (kvaps) merged commit 749110a into cozystack:main Jan 17, 2025
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jan 17, 2025
@kingdonb
Kingdon Barrett (kingdonb) deleted the update-flux branch January 22, 2025 05:06
@coderabbitai coderabbitai Bot mentioned this pull request Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@kvaps Andrei Kvapil (kvaps) kvaps approved these changes

Assignees

No one assigned

Labels

kind/documentation Categorizes issue or PR as related to documentation kind/feature Categorizes issue or PR as related to a new feature lgtm This PR has been approved by a maintainer size/M This PR changes 30-99 lines, ignoring generated files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kingdonb @kvaps