Skip to content

fix kubeconfig - #515

Merged
Andrei Kvapil (kvaps) merged 2 commits into
cozystack:mainfrom
klinch0:bugfix/fix-kubeconfig
Dec 9, 2024
Merged

fix kubeconfig#515
Andrei Kvapil (kvaps) merged 2 commits into
cozystack:mainfrom
klinch0:bugfix/fix-kubeconfig

Conversation

@klinch0

@klinch0 klinch0 commented Dec 5, 2024 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Enhanced Kubernetes configuration template for tenant-specific context, improving configurability and security.

  • Version Updates

    • Updated application version from 1.6.1 to 1.6.2.
    • Incremented version references for multiple packages, ensuring alignment with the latest commits.

@dosubot dosubot Bot added the size/XS This PR changes 0-9 lines, ignoring generated files label Dec 5, 2024
@coderabbitai

coderabbitai Bot commented Dec 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The pull request includes updates to the versioning of the tenant application and its related configurations. The Chart.yaml file version is incremented from 1.6.1 to 1.6.2. Additionally, the kubeconfig.yaml template has been modified to enhance tenant-specific configurability by replacing the hardcoded current-context with a dynamic value based on the tenant's name. Furthermore, updates to the versions_map reflect changes in various package versions, including the introduction of a new version for the tenant package.

Changes

File Change Summary
packages/apps/tenant/Chart.yaml Updated version from 1.6.1 to 1.6.2.
packages/apps/tenant/templates/kubeconfig.yaml Modified current-context to use tenant.name; updated retrieval of api-server-endpoint and ca.crt.
packages/apps/versions_map Updated tenant package version from 1.6.1 HEAD to 1.6.1 edbbb9be and added new version 1.6.2 HEAD; updated other package versions.

Possibly related PRs

Suggested labels

size:M, lgtm

Suggested reviewers

  • kvaps

Poem

In the garden of code, we hop with glee,
Versions updated, as bright as can be.
Tenant's name now shines in the config light,
With each little change, our future looks bright!
So let’s celebrate with a joyful cheer,
For every small tweak brings us all near! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 437b459 and 5298621.

📒 Files selected for processing (1)
  • packages/apps/tenant/templates/kubeconfig.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/apps/tenant/templates/kubeconfig.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

kvaps
Andrei Kvapil (kvaps) reviewed Dec 6, 2024
View reviewed changes
Comment thread packages/apps/tenant/templates/kubeconfig.yaml

@kvaps Andrei Kvapil (kvaps) Dec 6, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also remove

          - --skip-open-browser
          - --grant-type=password

by default

@klinch0 klinch0 Dec 9, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just stay --skip-open-browser for manual opening browser, but delete grant-type for using identity provider

kvaps
Andrei Kvapil (kvaps) approved these changes Dec 9, 2024
View reviewed changes

@kvaps Andrei Kvapil (kvaps) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Dec 9, 2024
@kvaps
Andrei Kvapil (kvaps) merged commit ccedc5f into cozystack:main Dec 9, 2024
@coderabbitai coderabbitai Bot mentioned this pull request Dec 9, 2024
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Dec 18, 2024
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Dec 30, 2024
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Feb 13, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Feb 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvaps Andrei Kvapil (kvaps) kvaps approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size/XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@klinch0 @kvaps