Skip to content

feat(kafka): add exporter - #408

Closed
George Gaál (gecube) wants to merge 4 commits into
mainfrom
add-kafka-exporter
Closed

feat(kafka): add exporter#408
George Gaál (gecube) wants to merge 4 commits into
mainfrom
add-kafka-exporter

Conversation

@gecube

@gecube George Gaál (gecube) commented Oct 9, 2024 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Add kafka exporter:

https://strimzi.io/blog/2019/10/14/improving-prometheus-metrics/
https://strimzi.io/docs/0.14.0/full#assembly-kafka-exporter-configuration-deployment-configuration-kafka

Summary by CodeRabbit

  • New Features
    • Updated Kafka application chart version to 0.3.1.
    • Introduced a new kafkaExporter section in the Kafka resource configuration, allowing for flexible matching of consumer groups and topics using regular expressions.
    • Added resource requests and limits for CPU and memory in the kafkaExporter configuration.

These enhancements improve the configuration capabilities for users managing Kafka resources.

@gecube
feat(kafka): add exporter
a2519a5 
Signed-off-by: George Gaál <gb12335@gmail.com>
@coderabbitai

coderabbitai Bot commented Oct 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The pull request includes updates to two files related to the Kafka application. The Chart.yaml file has its version number incremented from 0.3.0 to 0.3.1, while the kafka.yaml file introduces a new section for kafkaExporter within the spec, which includes three fields: groupRegex, topicRegex, and resources. The resources field specifies CPU and memory requests and limits, enhancing the configuration options for the Kafka exporter.

Changes

File Change Summary
packages/apps/kafka/Chart.yaml Version updated from 0.3.0 to 0.3.1. Application version remains unchanged at 3.7.0.
packages/apps/kafka/templates/kafka.yaml New section kafkaExporter added in spec, with fields groupRegex: ".*", topicRegex: ".*", and resource specifications for CPU and memory.

Poem

In the land of Kafka, changes take flight,
A version updated, oh what a sight!
With regex patterns, we now can explore,
Consumer groups and topics, we’ll match even more!
Hopping with joy, we celebrate this day,
For flexibility blooms in a wonderful way! 🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9e29401 and b065dc5.

📒 Files selected for processing (1)
  • packages/apps/kafka/templates/kafka.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/apps/kafka/templates/kafka.yaml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

themoriarti
Marian Koreniuk (themoriarti) approved these changes Oct 9, 2024
View reviewed changes

@themoriarti Marian Koreniuk (themoriarti) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I add resource request and limiting for kafka exporter.

themoriarti
Marian Koreniuk (themoriarti) approved these changes Oct 9, 2024
View reviewed changes

@themoriarti Marian Koreniuk (themoriarti) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix conflicts

@klinch0 klinch0 closed this Apr 9, 2025
auto-merge was automatically disabled April 9, 2025 14:33

Pull request was closed

Aleksei Sviridkin (lexfrei) added a commit that referenced this pull request Mar 23, 2026
@lexfrei
[kilo] Switch from fork to upstream squat/kilo
b43b7b2 
All functional patches from the cozystack/kilo fork have been
upstreamed and included in squat/kilo v0.7.0:
- --internal-cidr flag (PR #403)
- allowed-location-ips overlap fix (PR #404)
- Auto-detect WireGuard MTU (PR #406)
- Preferred source for WireGuard routes (PR #408)
- Cilium IPIP overlay support (PR #409)

The fork only contained rebranding and CI-specific commits beyond
upstream, which are no longer needed.

Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
@lexfrei Aleksei Sviridkin (lexfrei) mentioned this pull request Mar 23, 2026
Merged
Kirill Ilin (sircthulhu) added a commit that referenced this pull request Mar 26, 2026
@sircthulhu
[kilo] Switch from fork to upstream squat/kilo (#2259)
f13e68a 
## What this PR does

Switch kilo from the cozystack/kilo fork to the upstream squat/kilo
repository (v0.7.0).

All functional patches from the fork have been upstreamed:
- `--internal-cidr` flag for IP auto-detection filtering (#403)
- Allowed-location-ips overlap with node IPs fix (#404)
- Auto-detect WireGuard MTU from underlay interface (#406)
- Preferred source for WireGuard routes (#408)
- Cilium IPIP overlay support (#409)

The fork only retained rebranding and CI-specific commits beyond
upstream, which are no longer needed.

Changes:
- Makefile: point to `squat/kilo` repo and `ghcr.io/squat/kilo` image
- values.yaml: updated via `make update` to `0.7.0` with digest pin

### Release note

```release-note
[kilo] Switch from cozystack/kilo fork to upstream squat/kilo v0.7.0
```


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Updates**
* Updated the kilo component to use a different source repository and
new version configuration.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvaps Andrei Kvapil (kvaps) Awaiting requested review from kvaps kvaps is a code owner
1 more reviewer
@themoriarti Marian Koreniuk (themoriarti) themoriarti approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gecube @themoriarti @klinch0