Skip to content

fix(rabbitmq): raise default resources preset to u1.nano - #3936

Open
gettyeuro (yankawai) wants to merge 1 commit into
cozystack:mainfrom
yankawai:tech-1466-rabbit-memory
Open

fix(rabbitmq): raise default resources preset to u1.nano#3936
gettyeuro (yankawai) wants to merge 1 commit into
cozystack:mainfrom
yankawai:tech-1466-rabbit-memory

Conversation

@yankawai

@yankawai gettyeuro (yankawai) commented Aug 21, 2026

Copy link
Copy Markdown

What this PR does

Raises the RabbitMQ default resource preset from t1.nano (128Mi memory) to u1.nano (1Gi memory). An explicit t1.nano remains valid, and existing application CRs that already persist resourcesPreset: t1.nano are not resized automatically.

The original default-sized RabbitMQ 4.2 pod on Cozystack 1.6.1 was OOMKilled with exit 137, reached 10 restarts, and never became Ready. A temporary u1.nano canary reached 3/3 Ready with zero restarts; its working-set snapshots were 114–121Mi. The canary and its storage were removed after validation.

The values, generated schema, ApplicationDefinition, typed API, and README use the same default. Tests cover the new default, an explicit legacy override, and explicit resources.

Validation:

Screenshots

Not a UI change.

Downstream repositories

The default is restated by the Terraform provider, so the linked provider PR updates it and documents the state-plan implication. No other trigger-map entry matches this diff.

Release note

fix(rabbitmq): raise the default resource preset from t1.nano to u1.nano to prevent default-sized brokers from exhausting memory

@github-actions github-actions Bot added size/M This PR changes 30-99 lines, ignoring generated files area/uncategorized PR auto-labeler could not map title scope to a known area/*; please review kind/bug Categorizes issue or PR as related to a bug labels Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3e37569a-f47d-4194-90bc-138624c1dc34

📥 Commits

Reviewing files that changed from the base of the PR and between 3c780ac and 9576d34.

📒 Files selected for processing (7)
  • api/apps/v1alpha1/rabbitmq/types.go
  • packages/apps/rabbitmq/Makefile
  • packages/apps/rabbitmq/README.md
  • packages/apps/rabbitmq/tests/resources_test.yaml
  • packages/apps/rabbitmq/values.schema.json
  • packages/apps/rabbitmq/values.yaml
  • packages/system/rabbitmq-rd/cozyrds/rabbitmq.yaml

Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

RabbitMQ now uses u1.nano as the default resource preset. The system schema adds u1.4xlarge. Helm tests cover default resources, legacy t1.nano compatibility, and explicit resource precedence.

Changes

RabbitMQ resource configuration

Layer / File(s) Summary
Update resource preset contracts and defaults
api/apps/v1alpha1/rabbitmq/types.go, packages/apps/rabbitmq/values.yaml, packages/apps/rabbitmq/values.schema.json, packages/system/rabbitmq-rd/cozyrds/rabbitmq.yaml, packages/apps/rabbitmq/README.md
RabbitMQ defaults now use u1.nano. The system schema adds u1.4xlarge. Documentation describes the u1.nano resources and preset compatibility.
Validate rendered resource behavior
packages/apps/rabbitmq/Makefile, packages/apps/rabbitmq/tests/resources_test.yaml
The chart adds a Helm unit-test target. Tests validate the u1.nano default, explicit t1.nano, and explicit resource precedence.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 9576d

The PR raises RabbitMQ's default resource preset while preserving the legacy explicit override and covering the supported configurations with tests. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: kvaps

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (6 skipped: 6 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: raising RabbitMQ's default resources preset to u1.nano.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Yan Bondarenko <202671653+yankawai@users.noreply.github.com>
@yankawai
gettyeuro (yankawai) force-pushed the tech-1466-rabbit-memory branch 2 times, most recently from cc95aa3 to d5ff93b Compare August 21, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/uncategorized PR auto-labeler could not map title scope to a known area/*; please review kind/bug Categorizes issue or PR as related to a bug size/M This PR changes 30-99 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant