Skip to content

[Backport release-1.5] fix(keycloak-configure): patch HelmRelease in release namespace on teardown - #3877

Merged
myasnikovdaniil merged 2 commits into
release-1.5from
backport-3372-to-release-1.5
Aug 19, 2026
Merged

[Backport release-1.5] fix(keycloak-configure): patch HelmRelease in release namespace on teardown#3877
myasnikovdaniil merged 2 commits into
release-1.5from
backport-3372-to-release-1.5

Conversation

@github-actions

Copy link
Copy Markdown

Description

Backport of #3372 to release-1.5.

…ardown

The pre-delete teardown Job clears the HelmRelease finalizers as its
final step, but targeted a hardcoded namespace that does not match the
namespace where the release and its RBAC live. The Job's Role and
RoleBinding are created in the release namespace and grant patch on the
HelmRelease by release name, so the ServiceAccount was Forbidden to patch
the HelmRelease in the hardcoded namespace. The Job errored and retried
forever, the HelmRelease stuck in Terminating, and the Helm release
wedged in "uninstalling", blocking any teardown or reinstall.

Target the release name and namespace so the patch matches the RBAC that
grants it. Add a helm-unittest pinning the rendered namespace.

Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Aleksei Sviridkin <f@lex.la>
(cherry picked from commit fd568de)
The chart ships tests/delete_test.yaml, but the package Makefile has no
`test:` target, and hack/helm-unit-tests.sh runs a package's suite only
when `make -C <dir> -n test` succeeds. The suite was therefore never
executed on this branch, so the namespace assertion added alongside the
teardown fix shipped as dead weight.

Add the target in the same form the other packages use. On main the same
three lines arrived via an unrelated login-theme commit rather than with
the fix itself, which is why the backport landed without them.

Verified by mutating the rendered patch back to the pre-fix hardcoded
`-n cozy-system`: all three tests go red, so the suite asserts something.

Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
@github-actions github-actions Bot added area/release Issues or PRs related to release tooling (changelog, backport, release pipeline) kind/bug Categorizes issue or PR as related to a bug size/M This PR changes 30-99 lines, ignoring generated files labels Aug 17, 2026
@myasnikovdaniil
myasnikovdaniil merged commit 55d2923 into release-1.5 Aug 19, 2026
10 of 13 checks passed
@myasnikovdaniil
myasnikovdaniil deleted the backport-3372-to-release-1.5 branch August 19, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/release Issues or PRs related to release tooling (changelog, backport, release pipeline) kind/bug Categorizes issue or PR as related to a bug size/M This PR changes 30-99 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants