[Backport release-1.5] fix(cozystack-basics): gate the hostname VAP policies on the VAP API - #3876
Merged
Merged
Conversation
Author
|
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-3409-to-release-1.5
git worktree add --checkout .worktree/backport-3409-to-release-1.5 backport-3409-to-release-1.5
cd .worktree/backport-3409-to-release-1.5
git reset --hard HEAD^
git cherry-pick -x 267ea513adeee270e97f8d91d21b6242fc09f8f1
git push --force-with-lease |
Backport of #3409 to release-1.5. gateway-hostname-policy.yaml and route-hostname-policy.yaml rendered their ValidatingAdmissionPolicy and binding documents unconditionally, so installing the chart against an API server that does not serve admissionregistration.k8s.io/v1/ValidatingAdmissionPolicy failed. Guard both on the capability, matching the existing pattern in packages/core/platform/templates/deletion-protection.yaml, and declare the capability in the two rendering test suites so they keep exercising the policies. hostname-policies-capability-gate_test.yaml pins the absent-API case at suite level, since helm-unittest merges per-test capabilities into the suite's rather than replacing them. The upstream change also gated a third template, ingress-hostname-policy.yaml. That legacy-Ingress hostname policy landed on main in d89ad7069 and was never backported, so it does not exist on release-1.5 and is deliberately excluded here: importing it would ship an unreviewed admission policy that starts rejecting tenant Ingress hostnames in a patch release. Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
myasnikovdaniil
force-pushed
the
backport-3409-to-release-1.5
branch
from
August 17, 2026 15:29
0efaf26 to
9de1f16
Compare
myasnikovdaniil
marked this pull request as ready for review
August 17, 2026 16:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #3409 to
release-1.5.