fix(telemetry): make the documented opt-out cover both collectors by kvaps · Pull Request #3791 · cozystack/cozystack

Andrei Kvapil (kvaps) · 2026-08-12T19:08:33Z

What this PR does

Telemetry is reported by two components — cozystack-operator (cluster facts) and cozystack-controller (application counts) — but only the operator had a reachable switch.

The documented opt-out sets cozystackOperator.disableTelemetry on the cozy-installer chart. That chart deploys the operator; it cannot reach a package the platform deploys. packages/system/cozystack-controller has its own independent disableTelemetry key that nothing propagated to, so after an operator had followed the published procedure the controller kept posting cozy_application_count every 15 minutes. Nothing failed, and nothing indicated the opt-out was partial.

Two changes:

packages/core/platform gains a telemetry.disabled key and threads it into the cozystack-controller component of the cozystack.cozystack-engine Package — the same mechanism the bundle already uses for cilium, multus and linstor values.
packages/core/installer/values.yaml declares cozystackOperator.disableTelemetry. It was only ever referenced from the template, so the --set target the documentation names did not appear in the chart's own values.

Both keys default to false. Nobody who has not opted out sees a behaviour change.

The opt-out remains two steps, because the two collectors are installed by two different charts. Collapsing it into one knob would mean the operator writing the value into the platform Package it does not own, which is a design change rather than a fix.

helm unittest on the platform chart: 137 passed (133 before, plus the four added here). helm lint clean on both charts.

Screenshots

Not a UI change.

Downstream repositories

Trigger map walked against the diff. packages/core/platform/values.yaml changed, which the map routes to the website's hand-written platform-package table; the same change also makes the published opt-out procedure wrong, so the docs follow-up covers both.

Release note

fix(telemetry): the documented telemetry opt-out now covers both collectors. Setting `cozystackOperator.disableTelemetry=true` alone left `cozystack-controller` reporting application counts; the platform gains a `telemetry.disabled` key that silences it. Both default to false.

Summary by CodeRabbit

New Features
- Added a platform telemetry opt-out setting, disabled by default.
- Added a separate operator telemetry opt-out setting, also disabled by default.
- Applying the platform setting now disables telemetry reporting for the relevant controller.
Bug Fixes
- Ensured telemetry settings are correctly applied across supported platform variants while preserving existing configuration overrides.

Telemetry is reported by two components, cozystack-operator (cluster facts) and cozystack-controller (application counts), but only the operator had a reachable switch. The documented opt-out sets cozystackOperator.disableTelemetry on the cozy-installer chart, which cannot reach a package the platform deploys, so cozystack-controller kept reporting after an operator had followed the procedure — silently, with nothing to indicate the opt-out was partial. The platform now exposes telemetry.disabled and threads it into the cozystack-controller component of the cozystack-engine Package, the same way the bundle already threads cilium, multus and linstor values. The installer key is also declared in values.yaml: it was only ever referenced from the template, so the documented --set target did not appear in the chart's own values. Both keys stay false by default; this changes no behaviour for anyone who has not opted out. Assisted-By: Claude Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

coderabbitai · 2026-08-12T19:08:42Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2047b7c7-401a-4b8c-b142-48fc388609e6

📥 Commits

Reviewing files that changed from the base of the PR and between e944619 and c3cead8.

📒 Files selected for processing (4)

packages/core/installer/values.yaml
packages/core/platform/templates/bundles/system.yaml
packages/core/platform/tests/bundles_telemetry_optout_test.yaml
packages/core/platform/values.yaml

📝 Walkthrough

Walkthrough

The change adds separate platform and operator telemetry settings. The system bundle propagates platform telemetry opt-out to cozystack-controller. Bundle tests cover enabled, default, OIDC, and generic variants.

Changes

Telemetry opt-out

Layer / File(s)	Summary
Telemetry configuration `packages/core/platform/values.yaml`, `packages/core/installer/values.yaml`	Adds `telemetry.disabled` and `cozystackOperator.disableTelemetry`, both defaulting to `false`.
Bundle wiring and validation `packages/core/platform/templates/bundles/system.yaml`, `packages/core/platform/tests/bundles_telemetry_optout_test.yaml`	Passes `disableTelemetry: true` to `cozystack-controller` when platform telemetry is disabled. Tests cover default, OIDC, `isp-full`, and `isp-full-generic` variants.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: lexfrei

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: extending the documented telemetry opt-out to cover both collectors.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/telemetry-optout-covers-controller

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-19T20:24:49Z

Created backport PR for release-1.6:

[Backport release-1.6] fix(telemetry): make the documented opt-out cover both collectors #3916 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-3791-to-release-1.6
git worktree add --checkout .worktree/backport-3791-to-release-1.6 backport-3791-to-release-1.6
cd .worktree/backport-3791-to-release-1.6
git reset --hard HEAD^
git cherry-pick -x c3cead8f6455ea9d98804ed6902c260f6c25c744
git push --force-with-lease

github-actions · 2026-08-19T20:24:51Z

Created backport PR for release-1.5:

[Backport release-1.5] fix(telemetry): make the documented opt-out cover both collectors #3917 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-3791-to-release-1.5
git worktree add --checkout .worktree/backport-3791-to-release-1.5 backport-3791-to-release-1.5
cd .worktree/backport-3791-to-release-1.5
git reset --hard HEAD^
git cherry-pick -x c3cead8f6455ea9d98804ed6902c260f6c25c744
git push --force-with-lease

github-actions Bot added size/L This PR changes 100-499 lines, ignoring generated files area/uncategorized PR auto-labeler could not map title scope to a known area/*; please review kind/bug Categorizes issue or PR as related to a bug labels Aug 12, 2026

Andrei Kvapil (kvaps) marked this pull request as ready for review August 12, 2026 20:58

Andrei Kvapil (kvaps) requested review from IvanHunters, Aleksei Sviridkin (lexfrei), Timofei Larkin (lllamnyp) and myasnikovdaniil as code owners August 12, 2026 20:58

Aleksei Sviridkin (lexfrei) approved these changes Aug 19, 2026

View reviewed changes

Aleksei Sviridkin (lexfrei) enabled auto-merge August 19, 2026 09:45

Aleksei Sviridkin (lexfrei) merged commit 0b8837e into main Aug 19, 2026
23 of 26 checks passed

Aleksei Sviridkin (lexfrei) deleted the fix/telemetry-optout-covers-controller branch August 19, 2026 09:51

Andrei Kvapil (kvaps) added backport Should change be backported on previous release backport-previous Backport target — previous release line labels Aug 19, 2026

github-actions Bot mentioned this pull request Aug 19, 2026

[Backport release-1.6] fix(telemetry): make the documented opt-out cover both collectors #3916

Draft

github-actions Bot mentioned this pull request Aug 19, 2026

[Backport release-1.5] fix(telemetry): make the documented opt-out cover both collectors #3917

Draft

Navigation Menu

Uh oh!

fix(telemetry): make the documented opt-out cover both collectors - #3791

fix(telemetry): make the documented opt-out cover both collectors#3791
Aleksei Sviridkin (lexfrei) merged 1 commit into
mainfrom
fix/telemetry-optout-covers-controller

Andrei Kvapil (kvaps) commented Aug 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 12, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Andrei Kvapil (kvaps) commented Aug 12, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does

Screenshots

Downstream repositories

Release note

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Andrei Kvapil (kvaps) commented Aug 12, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 12, 2026 •

edited

Loading