Skip to content

[Backport release-1.6] fix(kubernetes): render the talos-reconcile Job for the default md0 group - #3536

Merged
myasnikovdaniil merged 1 commit into
release-1.6from
backport-3535-to-release-1.6
Aug 4, 2026
Merged

[Backport release-1.6] fix(kubernetes): render the talos-reconcile Job for the default md0 group#3536
myasnikovdaniil merged 1 commit into
release-1.6from
backport-3535-to-release-1.6

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Description

Backport of #3535 to release-1.6.

…roup

The Job in templates/talos/talos-reconcile-job.yaml is the only
producer of the TalosConfigTemplate that each worker
MachineDeployment names in spec.template.spec.bootstrap.configRef;
cluster.yaml renders the reference but deliberately not the object.
Its loop read .Values.nodeGroups directly, while the
MachineDeployment loop reads the effective set through the
kubernetes.nodeGroups helper.

For a cluster that supplies no nodeGroups the two disagree: the
helper's else-branch emits the built-in md0 group, so the md0
MachineDeployment renders, but the raw map is empty and no Job
renders at all. Every Machine the cluster-autoscaler adds to md0
then blocks indefinitely on a TalosConfigTemplate that nothing will
ever create, and the KamajiControlPlane spec.network.certSANs patch
the same Job performs is skipped too.

Range over the helper so the Job set tracks the MachineDeployment
set exactly. No change for a cluster that declares its own groups,
and md0 stays removable: the helper's if-branch keeps a
user-supplied map authoritative.

The gap survived because every helm-unittest fixture and e2e suite
declares md0 explicitly. tests/nodegroups_default_test.yaml does
render the empty-nodeGroups case but lists only
templates/cluster.yaml, so it never looked at the Job. The new
suite pins both halves of the helper contract and fails without
this fix.

Fixes #3504

Assisted-By: Claude <noreply@anthropic.com>
Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
(cherry picked from commit 4e9c5ce)
@dosubot dosubot Bot added area/kubernetes Issues or PRs related to the tenant Kubernetes app backport Should change be backported on previous release kind/bug Categorizes issue or PR as related to a bug labels Aug 4, 2026
@myasnikovdaniil
myasnikovdaniil merged commit de8483c into release-1.6 Aug 4, 2026
7 checks passed
@myasnikovdaniil
myasnikovdaniil deleted the backport-3535-to-release-1.6 branch August 4, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/kubernetes Issues or PRs related to the tenant Kubernetes app backport Should change be backported on previous release kind/bug Categorizes issue or PR as related to a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant