Skip to content

fix cilium kubeProxyReplacement - #336

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
fix-cilium-kube-proxy
Sep 6, 2024
Merged

fix cilium kubeProxyReplacement#336
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
fix-cilium-kube-proxy

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented Sep 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This PR fixes regression introduced by #322

Tenant clusters have kubeProxyReplacement disabled, must be enabled

@coderabbitai

coderabbitai Bot commented Sep 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The changes involve the configuration of Cilium in Kubernetes networking. The kubeProxyReplacement feature has been removed from values-kubeovn.yaml, indicating a shift away from using Cilium for kube-proxy functionality. Conversely, this feature has been added to values.yaml, enabling it in that context. These modifications reflect a change in the networking strategy within the Kubernetes environment.

Changes

Files Change Summary
packages/system/cilium/values-kubeovn.yaml Removed kubeProxyReplacement: true, disabling kube-proxy replacement in this configuration.
packages/system/cilium/values.yaml Added kubeProxyReplacement: true, enabling kube-proxy replacement in this configuration.

Poem

In the meadow where the bunnies play,
Changes come, brightening the day.
Cilium's dance, a new way to flow,
With hops and jumps, we watch it grow!
A tweak here, a turn there,
Networking magic fills the air! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai Bot reviewed Sep 6, 2024
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1f83838 and 33f194e.

Files selected for processing (2)
  • packages/system/cilium/values-kubeovn.yaml (1 hunks)
  • packages/system/cilium/values.yaml (1 hunks)
Additional comments not posted (2)
packages/system/cilium/values.yaml (1)

2-2: Approved addition of kubeProxyReplacement.

The addition of kubeProxyReplacement: true is approved as it aligns with the PR objectives to enhance Cilium's integration with Kubernetes networking. However, ensure that this setting integrates well with other features like hubble, externalIPs, and nodePort to avoid any conflicts.

packages/system/cilium/values-kubeovn.yaml (1)

Line range hint 1-13: Approved removal of kubeProxyReplacement.

The removal of kubeProxyReplacement from values-kubeovn.yaml is approved as it aligns with the PR objectives to simplify the configuration. However, ensure that this change does not adversely affect the networking functionality or performance within the Kubernetes cluster.

@kvaps
Andrei Kvapil (kvaps) merged commit b537cc0 into main Sep 6, 2024
@kvaps
Andrei Kvapil (kvaps) deleted the fix-cilium-kube-proxy branch September 6, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kvaps