kubernetes: Allow upgrading existing node groups - #205
Merged
Conversation
Andrei Kvapil (kvaps)
force-pushed
the
kubernetes-nodegroups
branch
from
July 8, 2024 16:34
c1a7900 to
4cf39c0
Compare
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Andrei Kvapil (kvaps)
force-pushed
the
kubernetes-nodegroups
branch
from
July 8, 2024 17:58
4cf39c0 to
0cf66bc
Compare
Marian Koreniuk (themoriarti)
approved these changes
Jul 8, 2024
Marian Koreniuk (themoriarti)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces change to allow upgrading existing node groups for tenant Kubernetes cluster:
This fixes the error:
This is done by generating unique names for KubevirtMachineTemplate based on hash from spec. Old KubevirtMachineTemplates keep existing in the cluster until some MachineSet continues using them.