Fine-tuning Flux configuration - #196
Merged
Merged
Conversation
Don't set the `interval` so short on HelmReleases, with this many HelmReleases that really hamstrings the control plane. Also, copy the install/upgrade remediation config from system packages to the Kubernetes templates for addon packages (cilium, flux, ingress) - in my testing the ingress-nginx chart fails every time the first time. Maybe that should be filed as a separate issue, I haven't looked into detail, it is some issue related to a secret not being created. I assume it's a conflict with being installed at the same time as the cert-manager addon (but I'm not sure and I can't look into it now!) Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Andrei Kvapil (kvaps)
approved these changes
Jul 4, 2024
Andrei Kvapil (kvaps)
left a comment
Member
There was a problem hiding this comment.
LGTM, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #195
Don't set the
intervalso short on HelmReleases, with this many HelmReleases that really hamstrings the control plane.Also, copy the install/upgrade remediation config from system packages to the Kubernetes templates for addon packages (cilium, flux, ingress) - in my testing the ingress-nginx chart fails every time the first time. Maybe that should be filed as a separate issue, I haven't looked into detail, it is some issue related to a secret not being created, I think it said something related to an admission controller.
Looks as though it's a conflict with being installed at the same time as the cert-manager addon.