Tenant nginx ingress (fixes) - #191
Merged
Marian Koreniuk (themoriarti) merged 5 commits intoJun 28, 2024
Merged
Conversation
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
When the local apply is finished, we still have yet to resume. Flux is not "ok ok" until the HelmRelease is ready too. Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
where `helm upgrade` can find them for the post-renderer Otherwise, these variables will not be available in the fluxcd-kustomize.sh script Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
Kingdon Barrett (kingdonb)
force-pushed
the
tenant-nginx-ingress
branch
from
June 27, 2024 20:47
f29b098 to
5a9a6ea
Compare
Member
Author
|
I guess that makefile doesn't export local variables to forked processes unless you set them explicitly like this |
Signed-off-by: Kingdon Barrett <kingdon+github@tuesdaystudios.com>
|
|
||
| flux_is_ok() { | ||
| kubectl wait --for=condition=available -n cozy-fluxcd deploy/source-controller deploy/helm-controller --timeout=1s | ||
| kubectl wait --for=condition=ready -n cozy-fluxcd helmrelease/fluxcd --timeout=1s # to call "apply resume" below |
Member
Author
There was a problem hiding this comment.
I'm not sure this is necessary now that the bug is fixed in other part of the script, but it helped for debugging. wdyt
Marian Koreniuk (themoriarti)
approved these changes
Jun 28, 2024
Marian Koreniuk (themoriarti)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good
Marian Koreniuk (themoriarti)
merged commit Jun 28, 2024
07384c4
into
cozystack:tenant-nginx-ingress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am testing install with this PR #183 and I had some issues, these should help