Update Talos Linux v1.12.1 - #1877
Conversation
|
Caution Review failedThe pull request is closed. Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. 📝 WalkthroughWalkthroughSix Talos image profile YAMLs were updated from v1.11.3 to v1.12.1: baseInstaller imageRefs changed to v1.12.1, systemExtensions lists replaced with new 2025-11-25/related image versions and updated SHA256 digests, and output sections gained an outFormat field. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello Andrei Kvapil (@kvaps), I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant version upgrade for Talos Linux and its core components. It updates the operating system version, the base installer image, and all associated system extensions to "v1.12.1". This ensures that the system benefits from the latest features, bug fixes, and security enhancements provided by the newer Talos Linux release and its integrated modules. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates Talos Linux and its extensions from v1.11.3 to v1.12.1. The changes are consistent across all modified YAML profile files. My main feedback is to align the pull request's title and release note with the version bump to v1.12.1, as they currently state an incorrect version, which could cause confusion and issues with release tracking.
| platform: metal | ||
| secureboot: false | ||
| version: v1.11.3 | ||
| version: v1.12.1 |
There was a problem hiding this comment.
The version is updated to v1.12.1, but the pull request title ("Update Talos Linux v1.11.6") and release note ("Update Talos Linux v1.11.") are inconsistent with this change. To avoid confusion and ensure accurate release notes, please update the PR title and release note to reflect the update to v1.12.1.
| platform: metal | ||
| secureboot: false | ||
| version: v1.11.3 | ||
| version: v1.12.1 |
There was a problem hiding this comment.
The version is updated to v1.12.1, but the pull request title ("Update Talos Linux v1.11.6") and release note ("Update Talos Linux v1.11.") are inconsistent with this change. To avoid confusion and ensure accurate release notes, please update the PR title and release note to reflect the update to v1.12.1.
| platform: metal | ||
| secureboot: false | ||
| version: v1.11.3 | ||
| version: v1.12.1 |
There was a problem hiding this comment.
The version is updated to v1.12.1, but the pull request title ("Update Talos Linux v1.11.6") and release note ("Update Talos Linux v1.11.") are inconsistent with this change. To avoid confusion and ensure accurate release notes, please update the PR title and release note to reflect the update to v1.12.1.
| platform: metal | ||
| secureboot: false | ||
| version: v1.11.3 | ||
| version: v1.12.1 |
There was a problem hiding this comment.
The version is updated to v1.12.1, but the pull request title ("Update Talos Linux v1.11.6") and release note ("Update Talos Linux v1.11.") are inconsistent with this change. To avoid confusion and ensure accurate release notes, please update the PR title and release note to reflect the update to v1.12.1.
| platform: metal | ||
| secureboot: false | ||
| version: v1.11.3 | ||
| version: v1.12.1 |
There was a problem hiding this comment.
The version is updated to v1.12.1, but the pull request title ("Update Talos Linux v1.11.6") and release note ("Update Talos Linux v1.11.") are inconsistent with this change. To avoid confusion and ensure accurate release notes, please update the PR title and release note to reflect the update to v1.12.1.
| platform: nocloud | ||
| secureboot: false | ||
| version: v1.11.3 | ||
| version: v1.12.1 |
There was a problem hiding this comment.
The version is updated to v1.12.1, but the pull request title ("Update Talos Linux v1.11.6") and release note ("Update Talos Linux v1.11.") are inconsistent with this change. To avoid confusion and ensure accurate release notes, please update the PR title and release note to reflect the update to v1.12.1.
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/core/talos/images/talos/profiles/installer.yaml (1)
1-6: Commit message does not match the actual version in the generated files.The commit message states "Update Talos Linux v1.11.6", but all profile files in
packages/core/talos/images/talos/profiles/contain versionv1.12.1(see line 6 and line 13 in installer.yaml). The auto-generated files are consistent across all profiles (installer, metal, iso, kernel, initramfs, nocloud), confirming they were properly generated byhack/gen-profiles.sh. Update the commit message to reflect the actual versionv1.12.1.
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
4bed054 to
91f7a48
Compare
Signed-off-by: Andrei Kvapil kvapss@gmail.com
What this PR does
This PR updates Talos Linux which includes DRBD fixes:
Release note
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.