Allow specifying externalIPs for ingress-nginx - #164
Merged
Conversation
Andrei Kvapil (kvaps)
force-pushed
the
externalips-ingress
branch
from
June 10, 2024 19:20
33a000d to
78ce6c5
Compare
Andrei Kvapil (kvaps)
force-pushed
the
externalips-ingress
branch
from
June 10, 2024 19:23
78ce6c5 to
10bbcde
Compare
Marian Koreniuk (themoriarti)
approved these changes
Jun 14, 2024
Marian Koreniuk (themoriarti)
left a comment
Collaborator
There was a problem hiding this comment.
Looks good.
This was referenced Jun 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a configuration without load-balancer service, when all nodes of the cluster are responsible for routing traffic.
In this case we can provide user an oportunity to specify IP-addresses of the nodes which are used to recieve traffic.
These nodes will be used to route traffic to nginx-ingress pods.
fixes #158