[dashboard] Introduce VNC console - #1627
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThis PR adds VNC tab functionality to the dashboard factory for VirtualMachine and VMInstance resources, updates Docker build dependencies to new commits, and enhances nginx proxy configuration with HTTP 1.1 support and additional headers/timeouts for improved websocket and long-connection handling. Changes
Sequence DiagramsequenceDiagram
participant ensureFactory as ensureFactory()
participant vncTabPrefix as vncTabPrefix(kind)
participant vncTab as vncTab(prefix)
participant tabs as tabs array
ensureFactory->>vncTabPrefix: check CRD kind
alt VirtualMachine or VMInstance
vncTabPrefix-->>ensureFactory: return prefix, true
ensureFactory->>vncTab: construct VNC tab config
vncTab-->>ensureFactory: return tab object
ensureFactory->>tabs: append VNC tab
else Other kinds
vncTabPrefix-->>ensureFactory: return "", false
ensureFactory->>tabs: skip VNC tab
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
5ae4df7 to
c81b222
Compare
Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>
Signed-off-by: Andrei Kvapil kvapss@gmail.com
What this PR does
Release note
Summary by CodeRabbit
New Features
Chores