[cozy-lib] Fix: handling resources=nil - #1607

Walkthrough

Changed resource merging in packages/library/cozy-lib/templates/_resources.tpl to compute mergedMap from a guarded default: deepCopy({}) | mergeOverwrite(presetMap) when resources is missing, ensuring a well-defined merged map in both sanitize and defaulting paths. No public signatures changed.

Changes

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Template as _resources.tpl
    participant Merge as Merge Logic

    Caller->>Template: invoke resource processing
    alt resources present
        Template->>Merge: deepCopy(resources)
        Merge->>Merge: mergeOverwrite(presetMap)
        Merge-->>Template: mergedMap (from resources+presets)
    else resources absent
        Template->>Merge: deepCopy({})
        Merge->>Merge: mergeOverwrite(presetMap)
        Merge-->>Template: mergedMap (from presets only)
    end
    Template-->>Caller: sanitized resources

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Single-file change with a small, defensive conditional.
• Verify templating syntax correctness and that the empty-dict default behaves as intended in both sanitize and defaulting flows.
• Check downstream consumers for assumptions about presence/shape of mergedMap.

Suggested reviewers

• klinch0

🐰 A gentle hop through template art,
guards stitched in place, a safer start.
If resources skip their cue,
presets step in to carry through.
✨

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Summary of Changes

Hello Andrei Kvapil (@kvaps), I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a specific bug within the cozy-lib library related to resource management templates. It implements a crucial check to ensure that resource maps are correctly processed even when the input resources parameter is not provided, thereby enhancing the stability and reliability of resource configuration within the system.

Highlights

• Resource Handling Fix: The pull request introduces a fix to correctly handle scenarios where the resources variable passed to the _resources.tpl template is nil, preventing potential errors during resource map merging.
• Robust Template Logic: A conditional check has been added to ensure that the $mergedMap is properly initialized with $presetMap when $resources is nil, making the template more robust.

Successfully created backport PR for release-0.37:

• [Backport release-0.37] [cozy-lib] Fix: handling resources=nil #1610