[robotlb] add Hetzner Robotlb balancer - #1233

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

packages/core/platform/bundles/paas-full.yaml (1)

418-424: Add explicit dependsOn for hetzner-robotlb to ensure CNI readiness

• In packages/core/platform/bundles/paas-full.yaml, update the hetzner-robotlb entry (around line 419) to declare a dependency on the CNI charts:

-  optional: true
-  chart: cozy-hetzner-robotlb
-  namespace: cozy-hetzner-robotlb
+  optional: true
+  dependsOn: [cilium,kubeovn]
+  chart: cozy-hetzner-robotlb
+  namespace: cozy-hetzner-robotlb

• Since most network-level components (e.g. Metallb, GPU-operator) already specify dependsOn: [cilium,kubeovn], this ensures Helm waits for the CNI to be ready before installing robotlb.
• If the upstream cozy-hetzner-robotlb chart uses webhooks or installs CRDs, you may also need to include cert-manager (or other prerequisites) in its dependsOn. Please verify the chart’s requirements and adjust accordingly.

packages/system/hetzner-robotlb/charts/robotlb/values.yaml (1)

1-74: Missing replicas default breaks the Deployment template

deployment.yaml expects .Values.replicas, but the key is absent here. Add it to avoid the invalid <no value> rendered earlier.

@@
 fullnameOverride: ""
 
+# Number of robotlb replicas
+replicas: 1
+
 envs:

packages/core/platform/bundles/distro-hosted.yaml (1)

175-179: Same dependsOn caveat as noted in paas-full.yaml

See the earlier comment – the new release should likely depend on cilium/kubeovn to avoid install ordering issues.

packages/system/hetzner-robotlb/Chart.yaml (1)

1-3: Add minimal recommended chart metadata

Helm will happily install the chart as-is, but the chart is missing a description and type (and optionally appVersion / maintainers). Adding them improves helm search output and linting.

 apiVersion: v2
 name: hetzner-robotlb
+description: Helm umbrella chart for the Hetzner RobotLB operator
+type: application
+# The chart version is updated automatically during CI
 version: 0.1.3  # Placeholder, the actual version will be automatically set during the build process

packages/system/hetzner-robotlb/charts/robotlb/Chart.yaml (1)

1-6: Polish wording & add optional chart metadata

Nitpicks:

1. “loadbalancer” → “load balancer”.
2. Consider adding home, sources, and maintainers to meet chart-testing best practices.

-description: A Helm chart for robotlb (loadbalancer on hetzner cloud).
+description: RobotLB operator – layer-4 load balancer for Hetzner dedicated servers.
+
+# Optional but recommended
+home: https://github.com/intreecom/robotlb
+sources:
+  - https://github.com/intreecom/robotlb
+maintainers:
+  - name: IvanHunters
+    email: ivan@example.com

packages/system/hetzner-robotlb/charts/robotlb/templates/NOTES.txt (1)

1-4: Fix minor grammar & formatting in post-install notes

-The RobotLB Operator was successfully installed.
-Please follow the readme to create loadbalanced services.
-
-README: https://github.com/intreecom/robotlb
+RobotLB Operator was successfully installed.
+
+Follow the README to create load-balanced services:
+https://github.com/intreecom/robotlb

packages/system/hetzner-robotlb/charts/robotlb/templates/role.yaml (1)

6-6: Put toYaml on the next line for cleaner rendering & easier diffs

Although {{- will swallow the newline, having the template directive on its own line keeps the generated YAML readable and avoids accidental white-space issues when the surrounding logic changes.

-rules: {{- toYaml .Values.serviceAccount.permissions | nindent 2 }}
+rules:
+{{- toYaml .Values.serviceAccount.permissions | nindent 2 }}

packages/system/hetzner-robotlb/charts/robotlb/templates/deployment.yaml (1)

29-35: Avoid emitting empty securityContext blocks

When the map is empty the manifest will contain securityContext: {}.
While valid YAML, many teams prefer to omit empty fields altogether to keep manifests concise.

-      securityContext:
-        {{- toYaml .Values.podSecurityContext | nindent 8 }}
+      {{- with .Values.podSecurityContext }}
+      securityContext:
+        {{- toYaml . | nindent 8 }}
+      {{- end }}

packages/system/hetzner-robotlb/values.yaml (1)

1-81: Duplicate values files introduce drift – consolidate or document precedence

This top-level values.yaml diverges from the chart-local one (e.g., it contains replicas, different resources schema). Unless Helmfile/Kustomize deliberately layers this file over the chart, the two may fall out of sync.

Consider:

1. Deleting the duplicate.
2. Or, documenting clearly in the bundle how this outer file is merged so future edits happen in one place.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

packages/system/hetzner-robotlb/charts/robotlb/templates/deployment.yaml (1)

37-40: Missing liveness / readiness probes
The deployment runs a network-facing binary but lacks health probes. This impedes rollout/auto-healing safety.

Example addition (tweak paths/ports to match the app):

           command:
             - /usr/local/bin/robotlb
+          readinessProbe:
+            httpGet:
+              path: /healthz
+              port: 8080
+            initialDelaySeconds: 5
+            periodSeconds: 10
+          livenessProbe:
+            httpGet:
+              path: /healthz
+              port: 8080
+            initialDelaySeconds: 30
+            periodSeconds: 10

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro