[dashboard] swap visual editor and YAML editor; fix handling multiline string - #1227
Conversation
…e string Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
|
Caution Review failedThe pull request is closed. WalkthroughThe Dockerfiles for both the dashboard and kubeapps-apis components were updated to use a new commit hash for the Changes
Estimated code review effort1 (<10 minutes) Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Summary of Changes
Hello Andrei Kvapil (@kvaps), I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on updating the underlying kubeapps dependency for the dashboard and its associated APIs. The core purpose of this update is to integrate recent improvements to the dashboard's configuration editors, specifically addressing the default editor view and a bug related to multiline string handling.
Highlights
- Dependency Update: I've updated the
COMMIT_REFfor thecozystack/kubeappsrepository in both the dashboard and kubeapps-apis Dockerfiles. This pulls in the latest changes from the upstreamkubeappsproject. - Dashboard Editor Improvements: This dependency update is intended to incorporate changes that swap the visual editor and YAML editor in the dashboard, improving the user experience for configuration editing. It also includes a fix for handling multiline strings within the editor.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | Gemini (@gemini-code-assist) | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on Gemini (@gemini-code-assist) comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the COMMIT_REF for the kubeapps dependency in the Dockerfiles for both the dashboard and kubeapps-apis services. The change is straightforward. My review includes a suggestion to centralize the COMMIT_REF variable to avoid duplication and improve maintainability, as it is currently hardcoded in two separate Dockerfiles.
| WORKDIR /app | ||
|
|
||
| ARG COMMIT_REF=e1382f51c6db1bca0a8ecd454407c8e282fe0243 | ||
| ARG COMMIT_REF=cdf9095f50c74505870de337725d2a9d0bd20947 |
There was a problem hiding this comment.
This COMMIT_REF is also hardcoded in packages/system/dashboard/images/kubeapps-apis/Dockerfile. Duplicating this value across multiple files increases the maintenance burden and risk of inconsistencies during updates.
To improve maintainability, consider centralizing this value. The packages/system/dashboard/Makefile seems like a suitable place to define COMMIT_REF and pass it to docker build via --build-arg.
For example, in your Makefile:
COMMIT_REF := cdf9095f50c74505870de337725d2a9d0bd20947
# ... in image-dashboard and image-kubeapps-apis targets:
docker buildx build --build-arg COMMIT_REF=$(COMMIT_REF) ...This would ensure both images are built from the same source commit and simplifies future updates.
Signed-off-by: Andrei Kvapil kvapss@gmail.com
What this PR does
Release note
Summary by CodeRabbit