Skip to content

[cozystack-api] Fix updaing lists - #1171

Merged
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
fix-updating-lists
Jul 9, 2025
Merged

[cozystack-api] Fix updaing lists#1171
Andrei Kvapil (kvaps) merged 1 commit into
mainfrom
fix-updating-lists

Conversation

@kvaps

@kvaps Andrei Kvapil (kvaps) commented Jul 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Signed-off-by: Andrei Kvapil kvapss@gmail.com

What this PR does

When you update lists in cozystack objects, you might face with the error:

Warning: resource vminstances/mikrotik-demo is missing the kubectl.kubernetes.io/last-applied-configuration annotation which is required by kubectl apply. kubectl apply should only be used o
n resources created declaratively by either kubectl create --save-config or kubectl apply. The missing annotation will be patched automatically.
warning: error calculating patch from openapi v3 spec: unable to find api field "disks"
Error from server: error when applying patch:
{"metadata":{"annotations":{"kubectl.kubernetes.io/last-applied-configuration":"{\"apiVersion\":\"apps.cozystack.io/v1alpha1\",\"kind\":\"VMInstance\",\"metadata\":{\"annotations\":{},\"name
\":\"mikrotik-demo\",\"namespace\":\"tenant-vasya\"},\"spec\":{\"disks\":[{\"bus\":\"sata\",\"name\":\"mikrotik-system\"},{\"name\":\"mikrotik-iso\"}],\"instanceProfile\":\"ubuntu\",\"instan
ceType\":\"u1.medium\",\"running\":true}}\n"}},"spec":{"disks":[{"bus":"sata","name":"mikrotik-system"},{"name":"mikrotik-iso"}]}}
to:
Resource: "apps.cozystack.io/v1alpha1, Resource=vminstances", GroupVersionKind: "apps.cozystack.io/v1alpha1, Kind=VMInstance"
Name: "mikrotik-demo", Namespace: "tenant-vasya"
for: "/tmp/2": error when patching "/tmp/2": unable to find api field in struct JSON for the json field "disks"

This PR workarounds this.

Related to #1168

Release note

[cozystack-api] Fix updaing lists on cozystack objects

Summary by CodeRabbit

  • Enhancements
    • Made resource specifications more flexible by allowing any content under the specification property for dynamically registered resource kinds.

@coderabbitai

coderabbitai Bot commented Jul 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

The OpenAPI post-processing in the server configuration was updated to make the .spec property schemaless for each dynamically registered resource kind by setting its AdditionalProperties to an empty schema. This change occurs after deep copying the base Application schema and before saving the new resource definition.

Changes

File(s) Change Summary
pkg/cmd/server/start.go Modified OpenAPI post-processing to set .spec property as schemaless (allow arbitrary content) for each dynamic resource kind.

Possibly related PRs

Suggested labels

bug, size:M

Suggested reviewers

  • lllamnyp

Poem

🐇 In schemas deep where specs reside,
Now .spec lets all keys hide.
No strict shape to bind or bind,
Freedom for data of any kind.
A hop, a skip, a joyful cheer—
Schemaless specs are finally here! 🥕✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b3edf33 and 2c68eee.

📒 Files selected for processing (1)
  • pkg/cmd/server/start.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pkg/cmd/server/start.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kvaps
Andrei Kvapil (kvaps) force-pushed the fix-updating-lists branch 2 times, most recently from 2771d23 to b3edf33 Compare July 8, 2025 18:21
@kvaps
[cozystack-api] Fix updaing lists
2c68eee 
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
@kvaps
Andrei Kvapil (kvaps) merged commit cad57cd into main Jul 9, 2025
52 of 56 checks passed
@kvaps
Andrei Kvapil (kvaps) deleted the fix-updating-lists branch July 9, 2025 08:20
@coderabbitai coderabbitai Bot mentioned this pull request Jul 9, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jul 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lllamnyp Timofei Larkin (lllamnyp) Awaiting requested review from lllamnyp lllamnyp is a code owner
1 more reviewer
@klinch0 klinch0 klinch0 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kvaps @klinch0