Reviewing files that changed from the base of the PR and between 9dc21c6 and b4d7b05.

• packages/library/cozy-lib/templates/_resourcepresets.tpl (1 hunks)
• packages/library/cozy-lib/templates/_resources.tpl (3 hunks)
• packages/system/dashboard/values.yaml (1 hunks)
• packages/system/fluxcd-operator/values.yaml (1 hunks)
• packages/system/vertical-pod-autoscaler/values.yaml (2 hunks)
• scripts/migrations/16 (1 hunks)

• GitHub Check: Build

packages/system/dashboard/values.yaml (1)

30-32: ```shell
#!/bin/bash

Show the first 60 lines of the values.yaml under review

echo "=== packages/system/dashboard/values.yaml (lines 1-60) ==="
sed -n '1,60p' packages/system/dashboard/values.yaml

Search for redis.master in this values.yaml

echo "=== Searching for 'redis.master' in the same file ==="
grep -n "redis.master" packages/system/dashboard/values.yaml || echo "No direct redis.master found"

Locate Chart.yaml for this chart to inspect subchart dependencies

echo "=== Locate Chart.yaml under packages/system/dashboard ==="
fd Chart.yaml -t f packages/system/dashboard

If found, print its contents

if [ -f packages/system/dashboard/Chart.yaml ]; then
echo "=== packages/system/dashboard/Chart.yaml (lines 1-200) ==="
sed -n '1,200p' packages/system/dashboard/Chart.yaml
else
echo "Chart.yaml not found at expected path"
fi

</details>
<details>
<summary>packages/system/fluxcd-operator/values.yaml (1)</summary>

`10-14`: I need to confirm the exact resource settings in `packages/system/fluxcd-operator/values.yaml`. Let's extract the top of that file:


```shell
#!/bin/bash
# Show the first 50 lines to locate the resources block
sed -n '1,50p' packages/system/fluxcd-operator/values.yaml

# Search for the “resources:” section
rg -n "resources" packages/system/fluxcd-operator/values.yaml

packages/system/vertical-pod-autoscaler/values.yaml (1)

8-11: Verify VPA updater can operate with 10x memory reduction.

The memory reduction from 1100Mi to 110Mi (10x decrease) is extremely significant for the VPA updater component.

Please verify that the VPA updater can function properly with this dramatically reduced memory allocation, as VPA components typically need substantial memory for cluster analysis.

#!/bin/bash
# Description: Check VPA memory usage patterns and requirements
# Expected: Find VPA-related configurations and memory requirements

# Search for VPA memory-related configurations
rg -i "vpa.*memory|memory.*vpa|vertical.*pod.*autoscaler.*memory" --type yaml -A 3 -B 3

# Look for VPA resource requirements or recommendations
rg -i "vpa.*resource|vertical.*autoscaler.*resource" --type yaml -A 5

scripts/migrations/16 (2)

80-80: Verify the implications of setting appVersion to "*".

Setting appVersion to "*" for all resources might have unintended consequences for version tracking or compatibility checks.

Please verify that setting appVersion to "*" is the intended behavior and won't affect application lifecycle management.

---

57-60: Potential data loss: only CPU and memory are preserved.

The filter only keeps CPU and memory resources, discarding other important resources like ephemeral-storage, which might be needed by applications.

Please verify that discarding non-CPU/memory resources won't break existing applications:

#!/bin/bash
# Description: Check if any CRDs use resources other than CPU/memory
# Expected: Find usage of ephemeral-storage or other resource types

# Search for ephemeral-storage usage in the target CRDs
for crd in clickhouses etcds ferretdb httpcaches; do
  kubectl get "$crd.apps.cozystack.io" -A -o json 2>/dev/null | jq -r '
    .items[] | 
    select(. | paths | select(.[-1] == "ephemeral-storage") | length > 0) |
    "\(.metadata.namespace // "cluster-scoped")/\(.metadata.name)"
  ' 2>/dev/null || true
done

packages/library/cozy-lib/templates/_resourcepresets.tpl (3)

13-19: CPU values doubled across all presets.

The CPU allocations have been roughly doubled (e.g., nano: 125m → 250m, micro: 250m → 500m). This is a significant increase that should be validated against actual usage patterns.

Please verify that the increased CPU allocations align with observed workload requirements and don't lead to resource over-provisioning.

---

10-10: Template signature change requires verification.

The template now accepts a second $global parameter, which changes the API contract.

Please verify that all callers of this template have been updated to pass the global context:

#!/bin/bash
# Description: Find all usages of cozy-lib.resources.preset template
# Expected: All calls should now include global parameter

# Search for template calls
rg 'include.*cozy-lib\.resources\.preset' --type yaml -A 2 -B 2

---

42-43: ```shell
#!/bin/bash

Extract the cozy-lib.resources.sanitize function definition and body

sed -n '87,200p' packages/library/cozy-lib/templates/_resources.tpl

</details>
<details>
<summary>packages/library/cozy-lib/templates/_resources.tpl (5)</summary>

`4-9`: **LGTM: Appropriate default allocation ratios**

The default allocation ratios are well-chosen:
- Memory ratio of `1` means requests equal limits, which is standard for memory resources
- Ephemeral storage ratio of `40` allows for significant overcommitment, which is appropriate for ephemeral storage

---

`21-39`: **LGTM: Consistent pattern for allocation ratio functions**

The new functions follow the same pattern as the existing CPU allocation ratio function, maintaining consistency in the codebase.

---

`58-86`: **LGTM: Clear documentation with helpful examples**

The documentation clearly explains the new flat map input format and provides concrete examples. The breaking change from nested to flat structure is well-documented.

---

`93-95`: **LGTM: Proper validation prevents misuse**

The validation correctly prevents the old nested format usage, ensuring users migrate to the new flat structure. The error message is clear and actionable.

---

`97-115`: **LGTM: Consistent resource handling logic**

The logic correctly handles different resource types:
- CPU: Uses allocation ratio with decimal precision
- Memory: Uses allocation ratio with integer conversion
- Ephemeral storage: Uses allocation ratio with integer conversion  
- Other resources: Requests equal limits

The implementation is consistent and follows the documented behavior.

</details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->