[dashboard] Cumulative update - #1042
Merged
Merged
Conversation
Andrei Kvapil (kvaps)
requested review from
klinch0 and
Timofei Larkin (lllamnyp)
as code owners
June 9, 2025 23:31
Contributor
## Walkthrough
This update modifies CSS rules in a template to hide specific UI elements in the dashboard and updates the commit references in two Dockerfiles to use a new version of the Kubeapps repository. It also adds two new configuration parameters (`qps` and `burst`) to the `values.yaml` file under the `kubeappsapis` section. No changes were made to exported or public entities or to build logic outside the commit reference updates.
## Changes
| File(s) | Change Summary |
|-------------------------------------------------------------------------------------------------|--------------------------------------------------------------------------|
| packages/core/platform/templates/_helpers.tpl | Added CSS rules to hide `.header-version` and `.label.label-info-secondary` elements. |
| packages/system/dashboard/images/dashboard/Dockerfile<br>packages/system/dashboard/images/kubeapps-apis/Dockerfile | Updated `COMMIT_REF` to a new Kubeapps commit hash. |
| packages/system/dashboard/values.yaml | Added `qps` and `burst` parameters under `kubeappsapis` configuration. |
## Poem
> In the dashboard’s gentle light,
> Some labels now hide out of sight.
> With Docker builds, a version new,
> The code refreshed, the styles too.
> A rabbit hops, with CSS delight—
> “Invisible things make the UI right!”
> 🐇✨📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/core/platform/templates/_helpers.tpl (1)
72-77: Add context for CSS overrides
Hiding.header-versionand.label.label-info-secondarycould be non-obvious to future maintainers. Please add a brief comment explaining the intent.Apply this diff:
@@ -70,6 +70,9 .appview-first-row section[aria-labelledby="access-urls-title"] { width: 100%; } + /* Hide version badge to streamline header display */ + /* Hide secondary info labels that are not relevant to user view */ .header-version { display: none; } .label.label-info-secondary { display: none; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/core/platform/templates/_helpers.tpl(1 hunks)packages/system/dashboard/images/dashboard/Dockerfile(1 hunks)packages/system/dashboard/images/kubeapps-apis/Dockerfile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Build
- GitHub Check: pre-commit
🔇 Additional comments (1)
packages/system/dashboard/images/dashboard/Dockerfile (1)
4-4: Sync commit reference with kubeapps-apis image
UpdatedCOMMIT_REFtod89e721fcb3130de6027251b1befb0208fdbeb85for consistency across dashboard components.
No functional changes; looks good.
|
|
||
| FROM alpine AS source | ||
| ARG COMMIT_REF=dd02680d796c962b8dcc4e5ea70960a846c1acdc | ||
| ARG COMMIT_REF=d89e721fcb3130de6027251b1befb0208fdbeb85 |
Contributor
There was a problem hiding this comment.
💡 Verification agent
❓ Verification inconclusive
Confirm updated Kubeapps commit reference
The COMMIT_REF ARG has been updated to d89e721fcb3130de6027251b1befb0208fdbeb85, matching the dashboard image.
Ensure this commit exists in the cozystack/kubeapps repo before merging.
🏁 Script executed:
#!/bin/bash
# Verify that the new commit hash is present in the remote repository
git ls-remote https://github.com/cozystack/kubeapps.git d89e721fcb3130de6027251b1befb0208fdbeb85Length of output: 98
Verify Kubeapps commit reference using the GitHub API or a shallow fetch
The current git ls-remote check won’t locate a raw commit SHA (it only lists refs). Please confirm that d89e721fcb3130de6027251b1befb0208fdbeb85 actually exists in the cozystack/kubeapps repo by using one of these approaches:
• Using GitHub’s REST API:
curl -s -o /dev/null -w "%{http_code}\n" \
https://api.github.com/repos/cozystack/kubeapps/commits/d89e721fcb3130de6027251b1befb0208fdbeb85Expect an HTTP 200 status for a valid commit; 404 if it’s missing.
• Or fetch and validate locally:
git clone --no-checkout --depth=1 https://github.com/cozystack/kubeapps.git temp-repo
cd temp-repo
git fetch --depth=1 origin d89e721fcb3130de6027251b1befb0208fdbeb85
git cat-file -t d89e721fcb3130de6027251b1befb0208fdbeb85It should output commit.
Once you’ve confirmed the commit exists, you can safely merge this ARG update.
🤖 Prompt for AI Agents
In packages/system/dashboard/images/kubeapps-apis/Dockerfile at line 7, the
COMMIT_REF argument has been updated to a new commit SHA. The current
verification using git ls-remote is insufficient to confirm the commit exists in
the cozytsack/kubeapps repo. To fix this, verify the commit by either using the
GitHub REST API to check for an HTTP 200 response on the commit URL or by
performing a shallow fetch of the commit locally and confirming it is a valid
commit object. Only after confirming the commit exists should you proceed with
merging this update.
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Andrei Kvapil (kvaps)
force-pushed
the
upd-dashboard
branch
from
June 10, 2025 00:00
1199147 to
2669ab6
Compare
Closed
8 tasks
Andrei Kvapil (kvaps)
added a commit
that referenced
this pull request
Jun 16, 2025
This PR includes fixes and updates for cozystack dashboard: ### [fix client rate limiter](cozystack/kubeapps@b1467ce) fixes the error `client rate limiter Wait returned an error: context canceled` The QPS and Burst options were set after the kubernetes client initalized and had no effect The limits are also increased fivefold: ```diff - - --kube-api-qps=50.0 - - --kube-api-burst=100 + - --kube-api-qps=250.0 + - --kube-api-burst=500 ``` ### [fix relative urls](cozystack/kubeapps@e2153e2) Fixes regression introduced in #935 which suddenly removed previus workaround #102 Now the proper fix prepared. Related to upstream issue vmware-tanzu/kubeapps#7740 ### [remove version selector](cozystack/kubeapps@f412a6a) from both package insallation page and upgrading page <img width="505" alt="Screenshot 2025-06-10 at 1 47 10" src="proxy.php?url=https%3A%2F%2Fgithub.com%2Fcozystack%2Fcozystack%2Fpull%2F%3Ca+href%3D"https://github.com/user-attachments/assets/36068264-2878-4b82-a159-6c911f1c1eef">https://github.com/user-attachments/assets/36068264-2878-4b82-a159-6c911f1c1eef" /> now it always will default to the latest package version ### [always fetch details from the latest version](cozystack/kubeapps@741a7dd) If old package version installed it will display information from the latest package in repository. This and previus fix actually remove the need for having versions_map logic and pack multiple charts for the release. But informs user about newer versions and allows to perform upgrade on demand in specific time: <img width="423" alt="Screenshot 2025-06-10 at 1 52 53" src="proxy.php?url=https%3A%2F%2Fgithub.com%2Fcozystack%2Fcozystack%2Fpull%2F%3Ca+href%3D"https://github.com/user-attachments/assets/dd571c9f-c2bc-403f-9aa0-3d8853600241">https://github.com/user-attachments/assets/dd571c9f-c2bc-403f-9aa0-3d8853600241" /> ### [Remove plugin name from header]cozystack/kubeapps@ffc0b02 We always use flux though <img width="386" alt="Screenshot 2025-06-10 at 1 55 39" src="proxy.php?url=https%3A%2F%2Fgithub.com%2Fcozystack%2Fcozystack%2Fpull%2F%3Ca+href%3D"https://github.com/user-attachments/assets/df6f52b5-82ab-4e7a-a973-2a82eb38ebfb">https://github.com/user-attachments/assets/df6f52b5-82ab-4e7a-a973-2a82eb38ebfb" /> ### [Fix switching context from app view](cozystack/kubeapps@d89e721) Fixes the error message while swtiching tenant from the application view ``` An error occurred while fetching the application: Unable to get installed package. ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added new configuration options for API request rate limits in the dashboard settings. - **Style** - Updated dashboard appearance to hide version information and specific label elements. - **Chores** - Updated internal references to the latest version of the dashboard source code. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Andrei Kvapil (kvaps)
added a commit
that referenced
this pull request
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes fixes and updates for cozystack dashboard:
fix client rate limiter
fixes the error
client rate limiter Wait returned an error: context canceledThe QPS and Burst options were set after the kubernetes client initalized and had no effect
The limits are also increased fivefold:
fix relative urls
Fixes regression introduced in #935 which suddenly removed previus workaround #102
Now the proper fix prepared.
Related to upstream issue vmware-tanzu/kubeapps#7740
remove version selector
from both package insallation page and upgrading page
now it always will default to the latest package version
always fetch details from the latest version
If old package version installed it will display information from the latest package in repository. This and previus fix actually remove the need for having versions_map logic and pack multiple charts for the release. But informs user about newer versions and allows to perform upgrade on demand in specific time:
[Remove plugin name from header]cozystack/kubeapps@ffc0b02
We always use flux though
Fix switching context from app view
Fixes the error message while swtiching tenant from the application view
Summary by CodeRabbit
New Features
Style
Chores