[ci] Split build artefacts - #1010
Conversation
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
WalkthroughThe workflow configuration was updated to split artifact handling into two parts: the installer and the Talos image are now uploaded and downloaded as separate artifacts with distinct names and paths. The test job was adjusted to download these artifacts individually, and code checkout was removed from the test job. Changes
Sequence Diagram(s)sequenceDiagram
participant BuildJob
participant ArtifactStore
participant TestJob
BuildJob->>ArtifactStore: Upload "cozystack-installer"
BuildJob->>ArtifactStore: Upload "talos-image"
TestJob->>ArtifactStore: Download "cozystack-installer"
TestJob->>ArtifactStore: Download "talos-image"
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/pull-requests.yaml (2)
42-42: Remove trailing whitespace.Line 42 has unnecessary trailing spaces which can lead to lint errors.
Apply this diff to remove them:🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 42-42: trailing spaces
(trailing-spaces)
49-53: Approve splitting Talos image upload into its own artifact.Separating the Talos image (
nocloud-amd64.raw.xz) into its own artifact (talos-image) aligns with the PR objective of decoupling build outputs.Note: line 54 also contains trailing whitespace (see static analysis). Consider removing it:
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pull-requests.yaml(2 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/pull-requests.yaml
[error] 42-42: trailing spaces
(trailing-spaces)
[error] 54-54: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test
🔇 Additional comments (3)
.github/workflows/pull-requests.yaml (3)
43-48: Approve splitting installer upload into its own artifact.The new
Upload installerstep correctly isolates the installer file (cozystack-installer.yaml) as a separate build artifact, improving clarity and downstream handling.
65-69: Approve downloading the installer artifact.The
Download installerstep correctly retrieves thecozystack-installerartifact into_out/assets/, matching the upload path.
72-76: Approve downloading the Talos image artifact.The
Download Talos imagestep mirrors the upload configuration and ensures the image is available for testing.
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| - name: Download installer |
There was a problem hiding this comment.
Missing checkout in test job: tests won’t run without source.
The test job no longer checks out the repository, so make test will not find any code. Insert a checkout step before downloading artifacts. For example:
jobs:
test:
steps:
+ - name: Checkout code
+ uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ fetch-tags: true
- name: Download installer
uses: actions/download-artifact@v4📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| steps: | |
| - name: Checkout code | |
| uses: actions/checkout@v4 | |
| - name: Download installer | |
| jobs: | |
| test: | |
| steps: | |
| - name: Checkout code | |
| uses: actions/checkout@v4 | |
| with: | |
| fetch-depth: 0 | |
| fetch-tags: true | |
| - name: Download installer | |
| uses: actions/download-artifact@v4 |
🤖 Prompt for AI Agents
In .github/workflows/pull-requests.yaml around lines 64 to 65, the test job is
missing a checkout step, so the source code is not available for running tests.
Add a step to checkout the repository before the "Download installer" step to
ensure the code is present for the test commands.
Signed-off-by: Andrei Kvapil kvapss@gmail.com
Summary by CodeRabbit