Calculate tags and version automatically - #100
Merged
Merged
Conversation
Andrei Kvapil (kvaps)
force-pushed
the
dynamic-tags
branch
2 times, most recently
from
April 23, 2024 17:03
1c2baf9 to
dff30f7
Compare
Andrei Kvapil (kvaps)
marked this pull request as ready for review
April 23, 2024 17:04
Andrei Kvapil (kvaps)
force-pushed
the
dynamic-tags
branch
3 times, most recently
from
April 23, 2024 17:08
e6a7a01 to
e971fc3
Compare
Andrei Kvapil (kvaps)
requested review from
George Gaál (gecube) and
Marian Koreniuk (themoriarti)
April 23, 2024 17:10
Signed-off-by: Andrei Kvapil <kvapss@gmail.com>
Andrei Kvapil (kvaps)
force-pushed
the
dynamic-tags
branch
from
April 23, 2024 19:10
e971fc3 to
08676ec
Compare
Marian Koreniuk (themoriarti)
approved these changes
Apr 24, 2024
Marian Koreniuk (themoriarti)
left a comment
Collaborator
There was a problem hiding this comment.
Conceptually, everything is normal, but I did not check locally, if no one is against it, then we can merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves development experence:
Remove
prepare_release.shscriptCalucalte
TAGautomatically fromgit describe --tags --exact-matchand replaced tolatestfor in case if tag is not assigned.Allow overriding
REGISTRY=<docker_tag>andTAG=<git_tag>via makefile, eg:Enable in-line cache, which is now downloaded from
:latestimagesCalculate version and set automatically for the Helm charts from
git describe --tags --abbrev=0