fix(920240, 920400): don't rely on content-type header#4639
Open
EsadCetiner wants to merge 1 commit into
Open
Conversation
Contributor
|
📊 Quantitative test results for language: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Rules 920240 and 920400 relies on the Content Type header to perform urlencoding validation, and file size limits respectively. Some applications don't set content types correctly and will use something like
text/plain.The
REQBODY_PROCESSORvariable contains the same information a Content Type would, and would support more exotic configurations where urlencoded data is sent with atext/plaincontent type. Assuming the end user switches on the correct body processor fortext/plainand similar.PR Checklist
commentfield to write the expected behaviorFurther comments
AI Disclosure
N/A
For the reviewer
ctl:requestBodyAccess=Offwere used in the rule